WebRender clips should not share ServoScrollRootIds

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mrobinson, Assigned: mrobinson)

Tracking

Other Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/56.0.2924.76 Chrome/56.0.2924.76 Safari/537.36
When creating clipping / scrolling nodes the ServoScrollRootId is used to scroll and track scrolling position of nodes from the client. Previously it wasn't a problem to share these ids if they were unused, but WebRender has changed to the point where they must all be unique.
Created attachment 8847118 [details] [diff] [review]
Pass None as the argument to push_scroll_layer
Attachment #8847118 - Flags: review?(jmuizelaar)
Attachment #8847118 - Flags: review?(jmuizelaar) → review+

Comment 4

2 years ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/563b634aec44
WebRender clips should not share ServoScrollRootIds. r=jrmuizel
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/563b634aec44
Assignee: nobody → mrobinson
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.