1347178 - Port bug 1344629 to mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Jorg K (CEST = GMT+2)]

Fresh bustage:

mailnews/base/src/nsMessengerWinIntegration.cpp(964): error C2280: 'char16ptr_t nsLiteralString::get(void) const &&': attempting to reference a deleted function

mailnews/addrbook/src/nsAbMDBDirectory.cpp(86): error C2280: 'const mozilla::detail::nsCStringRepr::char_type *nsLiteralCString::get(void) const &&': attempting to reference a deleted function

Those callsites are:

deleteKey.Assign(NS_LITERAL_STRING(UNREADMAILNODEKEY).get());

rv = prefService->GetBranch(NS_LITERAL_CSTRING(PREF_LDAP_SERVER_TREE_NAME ".").get(), getter_AddRefs(prefBranch));

Comment 1

[Jorg K (CEST = GMT+2)]

I'll be unavailable for a few hours, but I'd try:
deleteKey.Assign(UNREADMAILNODEKEY);
and
prefService->GetBranch(PREF_LDAP_SERVER_TREE_NAME ".", getter_AddRefs(prefBranch));

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1347178-strings.patch

Need to go soon too so better not taking the bug. SeaMonkey compile is still running with the attached patch. Feel free to modify it if not working.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1347178-strings-V2.patch

This compiles. Not yet tested.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8847154 [details] [diff] [review]
1347178-strings-V2.patch

TB compiles too and doesn't crash on me so taking the bug.

Comment 5

[Richard Marti (:Paenglab)]

TB builds here too.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8847154 [details] [diff] [review]
1347178-strings-V2.patch

Review of attachment 8847154 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/7e17ca62288483103270b0cbbf0be018cac10f39

Comment 8

[Jorg K (CEST = GMT+2)]

Sorry I couldn't assist here since I've just returned to my desk.

NS_LITERAL_CSTRING() produces an one-byte string, so NS_LITERAL_CSTRING("huhu").get() can just be replaced with "huhu".

NS_LITERAL_STRING() produces an two-byte string, so NS_LITERAL_STRING("huhu").get() needs to be replaced with u"huhu".

But then you figured that out despite my partly incorrect comment #1.