1347179 - Perma Bustage when Aurora 54 moves to Beta in nsGlobalWindow.cpp:3470:23: error: unused variable 'contentOpener' [-Werror=unused-variable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, blocker)

Description

[Carsten Book [:Tomcat]]

/home/worker/workspace/build/src/dom/base/nsGlobalWindow.cpp:3470:23: error: unused variable 'contentOpener' [-Werror=unused-variable] 

found by uplift simulation that simulates aurora as beta

https://treeherder.mozilla.org/logviewer.html#?job_id=83713900&repo=try

Comment 1

[Carsten Book [:Tomcat]]

Michael, can you take a look, thanks

Comment 2

[:Nika Layzell (ni? for response)]

Attachment: Don't compute contentOpener when it won't be used

This should probably land on both aurora and nightly so we don't have this same problem in the next cycle ;).

MozReview-Commit-ID: 27LBQ0mGNaj

Comment 3

[:ehsan akhgari]

Comment on attachment 8847156 [details] [diff] [review]
Don't compute contentOpener when it won't be used

Review of attachment 8847156 [details] [diff] [review]:
-----------------------------------------------------------------

This is way too ugly and it forces one to look up the definition of MOZ_DIAGNOSTIC_ASSERT to evaluate its correctness.  This is why Unused was invented, please use it instead.

Comment 4

[:Nika Layzell (ni? for response)]

Attachment: Don't compute contentOpener when it won't be used

MozReview-Commit-ID: 27LBQ0mGNaj

Comment 5

[:ehsan akhgari]

Comment on attachment 8847203 [details] [diff] [review]
Don't compute contentOpener when it won't be used

Review of attachment 8847203 [details] [diff] [review]:
-----------------------------------------------------------------

The commit message needs updating too.  :-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0dc3ec81a5
Mark contentOpener as unused in some optimized builds, r=ehsan

Comment 7

[:Nika Layzell (ni? for response)]

Attachment: Mark contentOpener as unused in some optimized builds

MozReview-Commit-ID: 27LBQ0mGNaj

Comment 8

[:Nika Layzell (ni? for response)]

Comment on attachment 8847229 [details] [diff] [review]
Mark contentOpener as unused in some optimized builds

Approval Request Comment
[Feature/Bug causing the regression]: bug 1334086
[User impact if declined]: Beta builds of the aurora tree will fail.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Just landed
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just allows the code to build
[String changes made/needed]: None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8847229 [details] [diff] [review]
Mark contentOpener as unused in some optimized builds

avoid bustage when 54 moves to beta, aurora54+

Yay for fixing those early :)

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb0dc3ec81a5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e49b6dacff0f