Closed Bug 1347179 Opened 3 years ago Closed 3 years ago

Perma Bustage when Aurora 54 moves to Beta in nsGlobalWindow.cpp:3470:23: error: unused variable 'contentOpener' [-Werror=unused-variable]

Categories

(Core :: DOM: Core & HTML, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: cbook, Assigned: Nika)

References

()

Details

Attachments

(1 file, 2 obsolete files)

/home/worker/workspace/build/src/dom/base/nsGlobalWindow.cpp:3470:23: error: unused variable 'contentOpener' [-Werror=unused-variable] 

found by uplift simulation that simulates aurora as beta

https://treeherder.mozilla.org/logviewer.html#?job_id=83713900&repo=try
Michael, can you take a look, thanks
Flags: needinfo?(michael)
This should probably land on both aurora and nightly so we don't have this same problem in the next cycle ;).

MozReview-Commit-ID: 27LBQ0mGNaj
Attachment #8847156 - Flags: review?(ehsan)
Assignee: nobody → michael
Flags: needinfo?(michael)
Comment on attachment 8847156 [details] [diff] [review]
Don't compute contentOpener when it won't be used

Review of attachment 8847156 [details] [diff] [review]:
-----------------------------------------------------------------

This is way too ugly and it forces one to look up the definition of MOZ_DIAGNOSTIC_ASSERT to evaluate its correctness.  This is why Unused was invented, please use it instead.
Attachment #8847156 - Flags: review?(ehsan) → review-
MozReview-Commit-ID: 27LBQ0mGNaj
Attachment #8847203 - Flags: review?(ehsan)
Attachment #8847156 - Attachment is obsolete: true
Comment on attachment 8847203 [details] [diff] [review]
Don't compute contentOpener when it won't be used

Review of attachment 8847203 [details] [diff] [review]:
-----------------------------------------------------------------

The commit message needs updating too.  :-)
Attachment #8847203 - Flags: review?(ehsan) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0dc3ec81a5
Mark contentOpener as unused in some optimized builds, r=ehsan
MozReview-Commit-ID: 27LBQ0mGNaj
Attachment #8847203 - Attachment is obsolete: true
Comment on attachment 8847229 [details] [diff] [review]
Mark contentOpener as unused in some optimized builds

Approval Request Comment
[Feature/Bug causing the regression]: bug 1334086
[User impact if declined]: Beta builds of the aurora tree will fail.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Just landed
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just allows the code to build
[String changes made/needed]: None
Attachment #8847229 - Flags: approval-mozilla-aurora?
Comment on attachment 8847229 [details] [diff] [review]
Mark contentOpener as unused in some optimized builds

avoid bustage when 54 moves to beta, aurora54+

Yay for fixing those early :)
Attachment #8847229 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/bb0dc3ec81a5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.