Add Google Chrome tab background properties

NEW
Unassigned

Status

enhancement
P5
normal
2 years ago
10 months ago

People

(Reporter: mikedeboer, Unassigned)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: triaged)

User Story

Implement:

tints.background_tab

as part of chrome parity.
(Reporter)

Description

2 years ago
See (again) https://docs.google.com/spreadsheets/d/1YScpOVL5WdNDhQY2Nngh4YkK0bOpkfwJvpRjpMSxMWo/edit#gid=0

Constants as defined in https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/themes/theme_properties.h are:
 * COLOR_TAB_TEXT,
 * COLOR_BACKGROUND_TAB_TEXT,
 * TINT_BACKGROUND_TAB,
 * COLOR_BACKGROUND_TAB,
 * COLOR_TAB_THROBBER_SPINNING,
 * COLOR_TAB_THROBBER_WAITING,

It's important here to first implement the properties in the order and with names that fit with Firefox well and try to match these up with the Google equivalents above.

The 'throbber' properties are used by Google Chrome to apply an alternative color to the loading spinner that appears in place of a tabs' favicon. Implementing these may not be straightforward at the moment, thus may be moved forward to a separate bug.
(Reporter)

Updated

2 years ago
Duplicate of this bug: 1367284

Updated

2 years ago
Severity: normal → enhancement
Priority: -- → P5

Comment 2

2 years ago
 * COLOR_TAB_TEXT -> can be implemented
 * COLOR_BACKGROUND_TAB_TEXT -> currently implemented as tab_text (which should be changed)
 * TINT_BACKGROUND_TAB -> what is the difference with colors.background_tab ?
 * COLOR_BACKGROUND_TAB -> is it relevant with photon ?
 * COLOR_TAB_THROBBER_SPINNING -> --tab-loading-fill
 * COLOR_TAB_THROBBER_WAITING -> can be implemented

Updated

2 years ago
Depends on: 1415872

Updated

a year ago
No longer depends on: 1415872

Updated

a year ago
Summary: Add Google Chrome tab color properties → Add Google Chrome tab background and spinner color properties
>  * COLOR_TAB_TEXT -> can be implemented
fixed
>  * COLOR_BACKGROUND_TAB_TEXT -> currently implemented as tab_text (which
> should be changed)
fixed

>  * TINT_BACKGROUND_TAB -> what is the difference with colors.background_tab ?
>  * COLOR_BACKGROUND_TAB -> is it relevant with photon ?
left for this bug

>  * COLOR_TAB_THROBBER_SPINNING -> --tab-loading-fill
>  * COLOR_TAB_THROBBER_WAITING -> can be implemented
I've separated this out to bug 1426686.
Depends on: 1426686

Updated

a year ago
User Story: (updated)
No longer depends on: 1426686
Summary: Add Google Chrome tab background and spinner color properties → Add Google Chrome tab background properties
mass move of existing themes bugs to new WebExtensions: Themes component
Component: WebExtensions: Frontend → WebExtensions: Themes
It looks like Chrome only supports tints.background_tab. Removing colors.background_tab from user story.
User Story: (updated)

Updated

10 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.