1347238 - Add a check for rootNode in getAllGrids

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

console.error:
  Message: TypeError: rootNode is null
  Stack:
    getAllGrids@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:129:7
onNavigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:141:17
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
_navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1323:5
DebuggerProgressListener.prototype.onStateChange<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1667:9
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1347238 - Add a check for rootNode in getAllGrids.

Review commit: https://reviewboard.mozilla.org/r/121426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121426/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Forwarding this to you Patrick since jdescottes is on PTO

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8848499 [details]
Bug 1347238 - Add a check for rootNode in getAllGrids.

https://reviewboard.mozilla.org/r/121426/#review123960

Do we have tests for these actors? We do have actor tests in \devtools\server\tests\mochitest\. Not sure if this is still the best place for them these days, but I would like to see some tests added to cover these methods.
The great thing is we can add tests for edge cases like the one here and make sure these still work in the future.
Feel free to add this in another patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7684ec77d04
Add a check for rootNode in getAllGrids. r=pbro

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7684ec77d04