1347242 - Ansible changes for mozreview staging

Status: RESOLVED WONTFIX

(MozReview Graveyard :: Infrastructure, enhancement)

Description

[Kendall Libby [:fubar] (he/him)]

Filing for :glob for all of the ansible changes we'll need for the staging environment

Comment 1

[:glob ✱]

hosts:

reviewboard1.stage.webapp.scl3.mozilla.com
reviewboard2.stage.webapp.scl3.mozilla.com
reviewboard-hg1.stage.dmz.scl3.mozilla.com
reviewboard-hg2.stage.dmz.scl3.mozilla.com
reviewboard1.stage.db.scl3.mozilla.com
reviewboard2.stage.db.scl3.mozilla.com

fubar - i don't have ssh access to these systems (auth fail).
i'll need ssh+sudo access to the first four systems (along with everyone else listed in bug 1347936).

Comment 2

[:glob ✱]

hey fubar - i'm still unable to ssh to the stage infra.

Comment 3

[Kendall Libby [:fubar] (he/him)]

My bad, I was in the middle of adding the new vpn_team_mozreview_staging to access/sudoers, got distracted by looking for all of the changes needed in puppet to support the addition of a staging env (notably hiera stuff), and forgot to commit/push. Fixed. (many typos died to bring us this information)

Comment 4

[:glob ✱]

Attachment: ansible: move reviewboard-hg2 into a hgreview-prod group (bug 1347242);

Review commit: https://reviewboard.mozilla.org/r/125128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125128/

Comment 5

[:glob ✱]

Attachment: ansible: add rb-stage hosts to inventory, group like servers and comment (bug 1347242)

Review commit: https://reviewboard.mozilla.org/r/125130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125130/

Comment 6

[:glob ✱]

Attachment: ansible: duplicate deploy-mozreview-prod --> -stage (bug 1347242)

duplicate the main playbook in preparation for modifications for staging
deployment.

Review commit: https://reviewboard.mozilla.org/r/125132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125132/

Comment 7

[:glob ✱]

Attachment: ansible: update deploy-mozreview-stage to point to staging (bug 1347242);

Review commit: https://reviewboard.mozilla.org/r/125134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125134/

Comment 8

[:glob ✱]

Attachment: ansible: use bugzilla_url when available, set for stage deploy (bug 1347242)

Review commit: https://reviewboard.mozilla.org/r/125136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125136/

Comment 9

[:glob ✱]

Attachment: ansible: add mozreview-stage command to deploy (bug 1347242)

Review commit: https://reviewboard.mozilla.org/r/125138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125138/

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8853004 [details]
ansible: move reviewboard-hg2 into a hgreview-prod group (bug 1347242);

https://reviewboard.mozilla.org/r/125128/#review127812

::: ansible/mozreview-create-repo.yml:2
(Diff revision 1)
>  ---
> -- hosts: reviewboard-hg2.dmz.scl3.mozilla.com
> +- hosts: hgreview-prod

This works as long as there is a single host in the group. Otherwise, it wil run the playbook on multiple hosts.

For hgmo, we have a `hgssh-prod-master` group for single-homed actions.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8853005 [details]
ansible: add rb-stage hosts to inventory, group like servers and comment (bug 1347242)

https://reviewboard.mozilla.org/r/125130/#review127814

Comment 12

[Gregory Szorc [:gps]]

Comment on attachment 8853006 [details]
ansible: duplicate deploy-mozreview-prod --> -stage (bug 1347242)

https://reviewboard.mozilla.org/r/125132/#review127816

Please `hg cp` this file so history is preserved.

Comment 13

[Gregory Szorc [:gps]]

Comment on attachment 8853007 [details]
ansible: update deploy-mozreview-stage to point to staging (bug 1347242);

https://reviewboard.mozilla.org/r/125134/#review127818

::: ansible/deploy-mozreview-stage.yml:50
(Diff revision 1)
>        register: mozreview_config
>  
>    roles:
>      - {
>          role: hg-reviewboard,
> -        domain: "reviewboard-hg.mozilla.org",
> +        domain: "reviewboard-hg.allizom.org",

This should be a variable like everything else in this section.

::: ansible/deploy-mozreview-stage.yml:54
(Diff revision 1)
>          role: hg-reviewboard,
> -        domain: "reviewboard-hg.mozilla.org",
> +        domain: "reviewboard-hg.allizom.org",
>          bind_dn: "{{ (ldap_config.content | b64decode | from_json).username }}",
>          bind_pw: "{{ (ldap_config.content | b64decode | from_json).password }}",
>          ldap_uri: "{{ (ldap_config.content | b64decode | from_json).url }}",
> -        reviewboard_url: "https://reviewboard.mozilla.org",
> +        reviewboard_url: "https://reviewboard.allizom.org",

Ditto.

::: ansible/deploy-mozreview-stage.yml:75
(Diff revision 1)
>    roles:
>      - rbweb
>  
>    tasks:
>      - name: sync code from admin node
> -      command: /data/bin/update-www.sh reviewboard.mozilla.org
> +      command: /data/bin/update-www.sh reviewboard.allizom.org

Variable.

::: ansible/deploy-mozreview-stage.yml:90
(Diff revision 1)
>    post_tasks:
>      - name: wait for HTTP server to become available
>        wait_for: port=80
>  
>      - name: prime HTTP server
> -      shell: "for n in `seq 20`; do curl -H 'Host: reviewboard.mozilla.org' http://localhost/r/ > /dev/null; done"
> +      shell: "for n in `seq 20`; do curl -H 'Host: reviewboard.allizom.org' http://localhost/r/ > /dev/null; done"

Variable.

Comment 14

[Gregory Szorc [:gps]]

Comment on attachment 8853008 [details]
ansible: use bugzilla_url when available, set for stage deploy (bug 1347242)

https://reviewboard.mozilla.org/r/125136/#review127820

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 8853009 [details]
ansible: add mozreview-stage command to deploy (bug 1347242)

https://reviewboard.mozilla.org/r/125138/#review127822

There's a way to prevent the DRY violation and reuse the common decorators. But I don't think we care enough for this code.

Comment 16

[:glob ✱]

MozReview will be replaced by Conduit/Phabricator.