1347278 - Disable the Successful Step checkbox for TaskCluster jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P4)

Description

[Jonathan French (:jfrench)]

I had forgotten this morning poking around in the Logviewer that the Successful Steps UI and its checkbox don't apply to TC jobs; and I kept thinking something was awry when I was looking at build jobs from a TC group since nothing was happening when I clicked on the checkbox in Logviewer.

Since TC doesn't yet support 'successful step' display, let's disable the input and provide a suitable title when it's a TC log.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:disable-tc-success-steps > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8847282 [details] [review]
[treeherder] tojon:disable-tc-success-steps > mozilla:master

A few things I'd like changed, see PR for details

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8847282 [details] [review]
[treeherder] tojon:disable-tc-success-steps > mozilla:master

Ya, makes sense. I've made the change and squashed while I was at it.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/10430f39d761b367ec8b04bad5a7ec43558e18cb
Bug 1347278 - Disable Successful Step checkbox for TaskCluster jobs (#2253)

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8847282 [details] [review]
[treeherder] tojon:disable-tc-success-steps > mozilla:master

Thanks! :)

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on stage.