Closed Bug 1347278 Opened 8 years ago Closed 8 years ago

Disable the Successful Step checkbox for TaskCluster jobs

Categories

(Tree Management :: Treeherder, enhancement, P4)

Product:
Tree Management
Component:
Treeherder
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

Details

Attachments

(1 file)

[treeherder] tojon:disable-tc-success-steps > mozilla:master
47 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
I had forgotten this morning poking around in the Logviewer that the Successful Steps UI and its checkbox don't apply to TC jobs; and I kept thinking something was awry when I was looking at build jobs from a TC group since nothing was happening when I clicked on the checkbox in Logviewer. Since TC doesn't yet support 'successful step' display, let's disable the input and provide a suitable title when it's a TC log.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attachment #8847282 - Flags: review?(wlachance)
Comment on attachment 8847282 [details] [review] [treeherder] tojon:disable-tc-success-steps > mozilla:master A few things I'd like changed, see PR for details
Attachment #8847282 - Flags: review?(wlachance)
Comment on attachment 8847282 [details] [review] [treeherder] tojon:disable-tc-success-steps > mozilla:master Ya, makes sense. I've made the change and squashed while I was at it.
Attachment #8847282 - Flags: review?(wlachance)
Comment on attachment 8847282 [details] [review] [treeherder] tojon:disable-tc-success-steps > mozilla:master Thanks! :)
Attachment #8847282 - Flags: review?(wlachance) → review+
Verified fixed on stage.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Treeherder: Log Viewer → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: