Closed Bug 1347427 Opened 7 years ago Closed 7 years ago

Intermittent toolkit/components/places/tests/browser/browser_bug248970.js | Check the total items count - Got 17, expected 16

Categories

(Toolkit :: Places, defect, P1)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mak)

Details

(Keywords: intermittent-failure, Whiteboard: [fxsearch][stockwell fixed:obsolete])

Attachments

(1 file)

Bug 1347427 - Remove intermittent browser_bug248970.js test, cause it's not testing anything useful.
59 bytes, text/x-review-board-request
standard8
: review+
Details
Priority: -- → P3
Priority: P3 → P1
Whiteboard: [fxsearch]
this bug has 83 failures this week alone, all starting on July 11th on pretty much all configurations (not many windows failures though).

here is a recent linux64 debug log:
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=114431750&lineNumber=8994

and some related data from the log:
task 2017-07-14T18:20:57.792141Z] 18:20:57     INFO - TEST-START | toolkit/components/places/tests/browser/browser_bug248970.js
[task 2017-07-14T18:20:58.151184Z] 18:20:58     INFO - GECKO(3202) | ++DOMWINDOW == 14 (0x7fd1fd543800) [pid = 3202] [serial = 14] [outer = 0x7fd20c894800]
[task 2017-07-14T18:20:58.773422Z] 18:20:58     INFO - TEST-INFO | started process screentopng
[task 2017-07-14T18:21:00.703546Z] 18:21:00     INFO - TEST-INFO | screentopng: exit 0
[task 2017-07-14T18:21:00.717175Z] 18:21:00     INFO - Buffered messages logged at 18:20:57
[task 2017-07-14T18:21:00.717502Z] 18:21:00     INFO - Entering test bound 
[task 2017-07-14T18:21:00.720462Z] 18:21:00     INFO - Buffered messages finished
[task 2017-07-14T18:21:00.721811Z] 18:21:00     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/browser/browser_bug248970.js | Check the total items count - Got 16, expected 15
[task 2017-07-14T18:21:00.722059Z] 18:21:00     INFO - Stack trace:
[task 2017-07-14T18:21:00.723149Z] 18:21:00     INFO - chrome://mochikit/content/browser-test.js:test_is:967
[task 2017-07-14T18:21:00.724867Z] 18:21:00     INFO - chrome://mochitests/content/browser/toolkit/components/places/tests/browser/browser_bug248970.js:null:54
[task 2017-07-14T18:21:00.726166Z] 18:21:00     INFO - GECKO(3202) | ++DOCSHELL 0x7fd208067800 == 7 [pid = 3202] [id = {c38f3ce0-ab4c-4c02-b835-1b27358ce798}]
[task 2017-07-14T18:21:00.729186Z] 18:21:00     INFO - GECKO(3202) | ++DOMWINDOW == 15 (0x7fd208068000) [pid = 3202] [serial = 15] [outer = (nil)]
[task 2017-07-14T18:21:00.731867Z] 18:21:00     INFO - GECKO(3202) | ++DOMWINDOW == 16 (0x7fd208069000) [pid = 3202] [serial = 16] [outer = 0x7fd208068000]
[task 2017-07-14T18:21:00.736039Z] 18:21:00     INFO - GECKO(3202) | ++DOCSHELL 0x7fd1fb32a000 == 8 [pid = 3202] [id = {3898797a-5d95-4ff8-a284-70e04fb315f4}]
[task 2017-07-14T18:21:00.744166Z] 18:21:00     INFO - GECKO(3202) | ++DOMWINDOW == 17 (0x7fd1fb32a800) [pid = 3202] [serial = 17] [outer = (nil)]
[task 2017-07-14T18:21:00.746968Z] 18:21:00     INFO - GECKO(3202) | ++DOCSHELL 0x7fd1fb33a800 == 9 [pid = 3202] [id = {0088fc4f-60f7-46d1-aade-d4dcb386a4e3}]
[task 2017-07-14T18:21:00.749059Z] 18:21:00     INFO - GECKO(3202) | ++DOMWINDOW == 18 (0x7fd1fb33b000) [pid = 3202] [serial = 18] [outer = (nil)]
[task 2017-07-14T18:21:00.750927Z] 18:21:00     INFO - GECKO(3202) | ++DOMWINDOW == 19 (0x7fd1fb341800) [pid = 3202] [serial = 19] [outer = 0x7fd1fb33b000]
[task 2017-07-14T18:21:01.199599Z] 18:21:01     INFO - GECKO(3202) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpBR_79l.mozrunner/runtests_leaks_tab_pid3312.log
[task 2017-07-14T18:21:01.216779Z] 18:21:01     INFO - GECKO(3202) | [3312] WARNING: '!compMgr', file /home/worker/workspace/build/src/xpcom/components/nsComponentManagerUtils.cpp, line 63
[task 2017-07-14T18:21:01.253026Z] 18:21:01     INFO - GECKO(3202) | [Child 3312] WARNING: '!compMgr', file /home/worker/workspace/build/src/xpcom/components/nsComponentManagerUtils.cpp, line 63
[task 2017-07-14T18:21:01.531162Z] 18:21:01     INFO - GECKO(3202) | ++DOMWINDOW == 20 (0x7fd1fac6f000) [pid = 3202] [serial = 20] [outer = 0x7fd1fb32a800]
[task 2017-07-14T18:21:01.994192Z] 18:21:01     INFO - GECKO(3202) | --DOMWINDOW == 3 (0x7fcab664d800) [pid = 3247] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2017-07-14T18:21:03.063866Z] 18:21:03     INFO - TEST-PASS | toolkit/components/places/tests/browser/browser_bug248970.js |  - 
[task 2017-07-14T18:21:03.088248Z] 18:21:03     INFO - TEST-PASS | toolkit/components/places/tests/browser/browser_bug248970.js | Check if URI is in database - 
[task 2017-07-14T18:21:03.105096Z] 18:21:03     INFO - TEST-PASS | toolkit/components/places/tests/browser/browser_bug248970.js |  - 
[task 2017-07-14T18:21:03.126003Z] 18:21:03     INFO - GECKO(3202) | ++DOCSHELL 0x7fd13faef800 == 1 [pid = 3312] [id = {d65ebdb3-b168-40eb-bc17-e2b764655e90}]
[task 2017-07-14T18:21:03.143418Z] 18:21:03     INFO - TEST-PASS | toolkit/components/places/tests/browser/browser_bug248970.js | Check if URI is in database -

::mak, I see that you are the triage owner for toolkit::places, can you find someone from the places team to look into this bug and get it resolved in the next week given the high failure rate?
Flags: needinfo?(mak77)
Whiteboard: [fxsearch] → [fxsearch][stockwell needswork]
(In reply to Joel Maher ( :jmaher) (UTC-8) from comment #5)
> ::mak, I see that you are the triage owner for toolkit::places, can you find
> someone from the places team to look into this bug and get it resolved in
> the next week given the high failure rate?

This is already a P1 for the Search and Navigation Team, so we'll look into it soon, indeed we were already discussing this yesterday. (Side note: there's no Places team from many years, it's shared responsibility of the Desktop team to maintain Places).
Flags: needinfo?(mak77)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
After deeply looking into it, I think this test should just be removed!

The reasons it fails are mostly due to async initialization of the browser part of Places (import and such), and likely fixable with better test code but... The functionality of this test is better covered by browser_visituri_privatebrowsing_perwindowpb.js.

Indeed this test opens private and non private windows, but then it uses raw Places APIs to add bookmarks and visits, and to check if they are registered. Since those APIs have no knowledge of private browsing, the test is basically testing a few APIs that are already tested elsewhere, and the existence of a private browsing context is completely ignored.

Since it's unclear what was the original intent, and everything is covered by better tests, I'll just remove the test.
Comment on attachment 8887194 [details]
Bug 1347427 - Remove intermittent browser_bug248970.js test, cause it's not testing anything useful.

https://reviewboard.mozilla.org/r/157960/#review163356

What about the part where it is checking to see if a bookmark was updated in private browsing mode? Do we have that covered somewhere?
Comment on attachment 8887194 [details]
Bug 1347427 - Remove intermittent browser_bug248970.js test, cause it's not testing anything useful.

https://reviewboard.mozilla.org/r/157960/#review163356

That part is also not testing anything here, because it doesn't really look at the browser view, instead it runs a separate query that is completely unrelated to private browsing.
We could have a test like that, but I'd prefer to start it from scratch at this point. What I'm saying here is that by removing this test we don't lose any coverage.
Note that at most that bookmarking test would just be a sanity test, views are PB agnostic, as well as bookmarks. The only things that are affected by PB are history and favicons.
Comment on attachment 8887194 [details]
Bug 1347427 - Remove intermittent browser_bug248970.js test, cause it's not testing anything useful.

https://reviewboard.mozilla.org/r/157960/#review163390

Thanks for the clarification, lets do it!
Attachment #8887194 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/0be298129be1
Remove intermittent browser_bug248970.js test, cause it's not testing anything useful. r=standard8
https://hg.mozilla.org/mozilla-central/rev/0be298129be1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fxsearch][stockwell needswork] → [fxsearch][stockwell fixed]
Target Milestone: --- → mozilla56
Whiteboard: [fxsearch][stockwell fixed] → [fxsearch][stockwell fixed:obsolete]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: