Closed
Bug 1347454
Opened 7 years ago
Closed 7 years ago
J and K keyboard shortcuts now do the opposite of what I expect
Categories
(Tree Management :: Treeherder, enhancement)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: heycam, Assigned: jgraham)
References
Details
Attachments
(1 file)
It used to be that J selected the next unclassified job and K selected the previous one (matching vi keybindings). That seems to have recently reversed. Also, the "?" help window seems to list J and K twice, with opposite meanings.
Depends on: 1321798
|
Assignee | |
Comment 1•7 years ago
|
||
Oh, vi is weird. Apparently I assumed that k, being the rightmost key, moved you one to the right, and j one to the left. I can fix.
|
||
Comment 2•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8847523 -
Flags: review?(emorley)
|
||
Updated•7 years ago
|
Attachment #8847523 -
Flags: review?(emorley) → review+
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/9a4d2dea637ca6d6d1a328f0970fa9d8f3726553 Bug 1347454 - Make prev/next keybindings match vi again. (#2255) The autoclassify UI rewrite accidentially swapped the meaning of the j and k keys.
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Updated•7 years ago
|
Assignee: nobody → james
You need to log in
before you can comment on or make changes to this bug.
Description
•