1347459 - URL: protocol setter needs to be more restrictive around file

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P3)

Description

[Anne (:annevk)]

See new tests added in https://github.com/w3c/web-platform-tests/pull/5112 and standard changes at https://github.com/whatwg/url/pull/269.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 2

[Thomas Wisniewski [:twisniewski]]

Tests on wpt.fyi:

• https://wpt.fyi/results/url/url-setters-a-area.window.html%253Finclude%253Dfile
• https://wpt.fyi/results/url/url-setters-a-area.window.html%253Fexclude%253D(file%7Cjavascript%7Cmailto)
• https://wpt.fyi/results/url/url-setters.any.html%253Finclude%253Dfile
• https://wpt.fyi/results/url/url-setters.any.worker.html%253Finclude%253Dfile
• https://wpt.fyi/results/url/url-setters.any.html%253Fexclude%253D(file%7Cjavascript%7Cmailto)
• https://wpt.fyi/results/url/url-setters.any.worker.html%253Fexclude%253D(file%7Cjavascript%7Cmailto)

Comment 3

[Thomas Wisniewski [:twisniewski]]

I have a patch to address this in the works (although there are a couple of side-issues which will still prevent some of the related WPTs from passing).

Comment 4

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3cc5d306c99ab64dc77e8c1b2360e16a6492727b

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1347459 - make the link and URL protocol setters adhere to the URL spec text validating changes of protocol between file and/or special schemes; r?kershaw

Comment 6

[Thomas Wisniewski [:twisniewski]]

Note that even with this patch, some of the related WPTs will still fail:

• new URL("ssh://[e-mail]").protocol = "http" will keep the protocol the same as expected, but add an extra slash to the end: ssh://[e-mail]/
• new URL("file://hi/path").protocol = "s" will also keep the protocol the same as expected, but will drop the "hi" part of the URL and add a root slash: file:///path

I'm not quite sure what's causing those issues, but they appear to be preexisting and separate issues from what this patch touches, so I would rather address them in follow-up bugs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07dacad2b549
make the link and URL protocol setters adhere to the URL spec text validating changes of protocol between file and/or special schemes; r=kershaw,necko-reviewers

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/07dacad2b549