Update mach to download clang-format 5.0 r297730

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
Source Code Analysis
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We landed a few changes upstream, let's update clang-format to r297730

Build done with llvm & clang svn:
$ mkdir build
$ cd build 
$ gmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ../
$ make
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
I forgot two things:
* The declaration should be:
  parser.add_argument('-binary', default=os.path.expanduser("~") + '/.mozbuild/clang-format-5.0~svn297730',
in clang-format-diff
* import os is also needed then
Assignee: nobody → sledru
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8847555 [details]
Bug 1347474 - Update mach to download clang-format 5.0 r297730

https://reviewboard.mozilla.org/r/120516/#review122514

thnak you!
Attachment #8847555 - Flags: review?(bpostelnicu) → review+

Comment 5

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a654b91969e4
Update mach to download clang-format 5.0 r297730 r=andi
This will also work on mac and win

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a654b91969e4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.