Closed
Bug 1347474
Opened 7 years ago
Closed 7 years ago
Update mach to download clang-format 5.0 r297730
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
We landed a few changes upstream, let's update clang-format to r297730 Build done with llvm & clang svn: $ mkdir build $ cd build $ gmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ../ $ make
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
I forgot two things:
* The declaration should be:
parser.add_argument('-binary', default=os.path.expanduser("~") + '/.mozbuild/clang-format-5.0~svn297730',
in clang-format-diff
* import os is also needed thenAssignee: nobody → sledru
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847555 [details] Bug 1347474 - Update mach to download clang-format 5.0 r297730 https://reviewboard.mozilla.org/r/120516/#review122514 thnak you!
Attachment #8847555 -
Flags: review?(bpostelnicu) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a654b91969e4 Update mach to download clang-format 5.0 r297730 r=andi
|
|
||
Comment 6•7 years ago
|
||
This will also work on mac and win
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a654b91969e4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•