[RTL] LTR closing thumbnails action present on RTL too

VERIFIED FIXED in Firefox 54

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
4 months ago
29 days ago

People

(Reporter: Ioana Chiorean, Assigned: maliu)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 wontfix, firefox53 wontfix, firefox54 verified, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Firefox 55.0a1, 54.0a2, 53.0b2
Arabic on (Israeli or Hebrew)

Steps to reproduce:
1. Open several tabs 
2. Open tab drawer
3. Tab the right upper corner ( where the x would be in LTR)

Actual result:
- the tab closes

Expected result:
- the tab should not close

Note:
- see video: https://youtu.be/S5xYt_jarQ0
(Assignee)

Updated

4 months ago
Assignee: nobody → max
Comment hidden (mozreview-request)
Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

https://reviewboard.mozilla.org/r/120796/#review124354
Attachment #8847875 - Flags: review?(s.kaspari) → review+

Comment 3

3 months ago
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/98009da8586c
[RTL] Update TouchDelegate Rect for tab close button relatively, r=sebastian

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98009da8586c
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1319302
status-firefox52: affected → wontfix
status-firefox53: affected → wontfix
Should we consider fixing this in 54?
Flags: needinfo?(max)

Comment 6

a month ago
FWIW, I can confirm the bug is fixed on latest Nightly.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 7

a month ago
Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

Approval Request Comment
[Feature/Bug causing the regression]: RTL/CompatTabs
[User impact if declined]: Unexpected close tab when clicking on "CompatTab" opposite corner of close button.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Single file, small block, verified on Nightly.
[String changes made/needed]: None
Flags: needinfo?(max)
Attachment #8847875 - Flags: approval-mozilla-beta?
Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

fennec rtl fix, should be in 54.0b12
Attachment #8847875 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 9

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/1e504e2b2221
status-firefox54: affected → fixed
Verified as fixed in build AR - 54.0b12 with device: Huawei Honor (Android 5.1.1).
The tab is not closing when tapping the right upper corner - where "x" would be in LTR.
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.