59 bytes, text/x-review-board-request
Firefox 55.0a1, 54.0a2, 53.0b2 Arabic on (Israeli or Hebrew) Steps to reproduce: 1. Open several tabs 2. Open tab drawer 3. Tab the right upper corner ( where the x would be in LTR) Actual result: - the tab closes Expected result: - the tab should not close Note: - see video: https://youtu.be/S5xYt_jarQ0
Comment on attachment 8847875 [details] Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively, https://reviewboard.mozilla.org/r/120796/#review124354
Attachment #8847875 - Flags: review?(s.kaspari) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/98009da8586c [RTL] Update TouchDelegate Rect for tab close button relatively, r=sebastian
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox52: affected → wontfix
status-firefox53: affected → wontfix
Should we consider fixing this in 54?
FWIW, I can confirm the bug is fixed on latest Nightly.
Status: RESOLVED → VERIFIED
Comment on attachment 8847875 [details] Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively, Approval Request Comment [Feature/Bug causing the regression]: RTL/CompatTabs [User impact if declined]: Unexpected close tab when clicking on "CompatTab" opposite corner of close button. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Single file, small block, verified on Nightly. [String changes made/needed]: None
Attachment #8847875 - Flags: approval-mozilla-beta?
Comment on attachment 8847875 [details] Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively, fennec rtl fix, should be in 54.0b12
Attachment #8847875 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox54: affected → fixed
Verified as fixed in build AR - 54.0b12 with device: Huawei Honor (Android 5.1.1). The tab is not closing when tapping the right upper corner - where "x" would be in LTR.
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.