1347476 - [RTL] LTR closing thumbnails action present on RTL too

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ioana Chiorean]

Firefox 55.0a1, 54.0a2, 53.0b2
Arabic on (Israeli or Hebrew)

Steps to reproduce:
1. Open several tabs 
2. Open tab drawer
3. Tab the right upper corner ( where the x would be in LTR)

Actual result:
- the tab closes

Expected result:
- the tab should not close

Note:
- see video: https://youtu.be/S5xYt_jarQ0

Comment 1

[Max Liu [:maliu]]

Attachment: Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

Review commit: https://reviewboard.mozilla.org/r/120796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120796/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

https://reviewboard.mozilla.org/r/120796/#review124354

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98009da8586c
[RTL] Update TouchDelegate Rect for tab close button relatively, r=sebastian

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/98009da8586c

Comment 5

[Julien Cristau [:jcristau]]

Should we consider fixing this in 54?

Comment 6

[Itiel]

FWIW, I can confirm the bug is fixed on latest Nightly.

Comment 7

[Max Liu [:maliu]]

Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

Approval Request Comment
[Feature/Bug causing the regression]: RTL/CompatTabs
[User impact if declined]: Unexpected close tab when clicking on "CompatTab" opposite corner of close button.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Single file, small block, verified on Nightly.
[String changes made/needed]: None

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8847875 [details]
Bug 1347476 - [RTL] Update TouchDelegate Rect for tab close button relatively,

fennec rtl fix, should be in 54.0b12

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e504e2b2221

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed in build AR - 54.0b12 with device: Huawei Honor (Android 5.1.1).
The tab is not closing when tapping the right upper corner - where "x" would be in LTR.