1347587 - Toggle Toolbox buttons have a gray background that shouldn't be there

Status: RESOLVED INVALID

(DevTools :: Inspector, defect, P3)

Description

[Matteo Ferretti [:zer0] [:matteo]]

See the attachment: compared to before we have now a gray background when a toolbox button is checked.
The original UX design had only the light blue as stroke color (see the new RDM that is still following that), so now the toolbox buttons are inconsistent.

It seems a regression introduced by Bug 1340539 / Bug 1255116, but I'm not sure, it should be quite straight forward to fix this, but we don't want to impact any other buttons that maybe requires such background.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Tim, I think you can provide some insight if this is related to any of those bugs or not, and if I could accidentally impact other buttons changing the following rule (that seems the culprit): https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/common.css#338-344

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: toolbox-checked-button-screenshot.png

Almost forgot the attachment. :)

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Close as INVALID since we're going to fix this anyway because Photon.