1347603 - Implement a proper hook to filter diffset files, and fix tests

Status: RESOLVED INVALID

(MozReview Graveyard :: General, enhancement, P1)

Description

[Piotr Zalewa [:zalun]]

Bug 1346321 is fixed as a hotfix with the DownloadRawHook defined in newly created `fixuphook` instead of the `hooks` module. It is due to recursive import. Our extensions module is indirectly importing the `parser` module. As the issue is severe hotfix has been developed.

This bug is to be sure a hook will be implemented in the right, more elegant way.

Comment 1

[:glob ✱]

we'll also need to update the tests, as the commit-message file won't be exposed via dumpreview anymore (ie. there's no test to ensure it's created).

Comment 2

[Piotr Zalewa [:zalun]]

Tests updated, now it's time to place the hook in place.
Currently I've got such an error if DownloadRawHook is placed in reviewboard/extensions/hooks.py and removed the NoFilterDiffOpcodeGenerator:

rbweb>   File "/version-control-tools/pylib/mozreview/mozreview/extension.py", line 14, in <module>
rbweb>     from reviewboard.extensions.hooks import (AuthBackendHook,
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/extensions/hooks.py", line 11, in <module>
rbweb>     from reviewboard.accounts.backends import (register_auth_backend,
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/accounts/backends.py", line 31, in <module>
rbweb>     from reviewboard.accounts.models import LocalSiteProfile
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/accounts/models.py", line 19, in <module>
rbweb>     from reviewboard.reviews.models import Group, ReviewRequest
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/reviews/models/__init__.py", line 4, in <module>
rbweb>     from reviewboard.reviews.models.default_reviewer import DefaultReviewer
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/reviews/models/default_reviewer.py", line 8, in <module>
rbweb>     from reviewboard.reviews.managers import DefaultReviewerManager
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/reviews/managers.py", line 13, in <module>
rbweb>     from reviewboard.diffviewer.models import DiffSetHistory
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/diffviewer/models.py", line 14, in <module>
rbweb>     from reviewboard.diffviewer.managers import (RawFileDiffDataManager,
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/diffviewer/managers.py", line 19, in <module>
rbweb>     from reviewboard.scmtools.core import PRE_CREATION, UNKNOWN, FileNotFoundError
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/scmtools/core.py", line 19, in <module>
rbweb>     import reviewboard.diffviewer.parser as diffparser
rbweb>   File "/venv/lib/python2.6/site-packages/ReviewBoard-2.5.4.moz-py2.6.egg/reviewboard/diffviewer/parser.py", line 10, in <module>
rbweb>     from reviewboard.extensions.hooks import DownloadRawHook
rbweb> ImportError: cannot import name DownloadRawHook

Comment 3

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.