Closed Bug 1347616 Opened 4 years ago Closed 4 years ago

Handle invalid manifests

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 verified)

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(1 file)

Currently in Android if a user bookmarks a page with a manifest we attempt to install it, if that installation fails we silently ignore it.

This should happen rarely but when it does it will prevent the use from being able to bookmark that site. imo we can deal with this by showing an error and hopefully pushing for sites with invalid manifest to be fixed
Blocks: 1285858
flagging Jack for standalone mode UX
Flags: needinfo?(jalin)
(In reply to Dale Harvey (:daleharvey) from comment #0)
> Currently in Android if a user bookmarks a page with a manifest we attempt
> to install it, if that installation fails we silently ignore it.
> 
Quick question: 
Per current behavior (nightly) it only bookmarks the website even if it has manifest.
Though there's a guiding tip to let user further "add to homescreen".

Are we making the feature that bookmarking also adding (pwa) site to homescreen?
OK. I think the "bookmark" here means "add to homescreen".
Assignee: nobody → dale
Attachment #8851037 - Flags: review?(s.kaspari)
Hi Dale, 
Do you have an example website with invalid manifest, or you can make one so that we can play with it?
oh sorry I meant to mention that here, will be useful for QA too, https://www.washingtonpost.com/ is the test I have been using
(In reply to Dale Harvey (:daleharvey) from comment #6)
> oh sorry I meant to mention that here, will be useful for QA too,
> https://www.washingtonpost.com/ is the test I have been using

thanks. Both Opera and Chrome falls back to "added to homescreen" w/o standalone mode.
I didn't see specific error message or the need to have such message. 
I'll defer the call to UX.
Comment on attachment 8851037 [details] [diff] [review]
Fall back to bookmark when manifest invalid

Review of attachment 8851037 [details] [diff] [review]:
-----------------------------------------------------------------

Please let's not use the term bookmark. This has already a different meaning in the browser and overloading it will be super confusing (Unfortunately we already named the intent action "BOOKMARK" and that's something we can't change easily). App shortcut? Shortcut? Launcher icon? Launcher? Homescreen shortcut/icon? (FWIW Android seems to call it "shortcut" internally). But r+ for the code.
Attachment #8851037 - Flags: review?(s.kaspari) → review+
Ah yeh I didnt realise that, thanks. createBrowserShortcut seems descriptive enough and distinguish's it from createAppShortcut which is what is used for the webapps, will change
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07bba24c4f67
Fall back to bookmark when manifest invalid. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/07bba24c4f67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
i think we don't need UX input here anymore.
Flags: needinfo?(jalin)
Verified that when a web manifest is invalid (washingtonpost.com) or inexistent (nytimes.com), the shortcut created on the home screen behaves as before, opening the page in the browser, not as a standalone app.
Build: Nightly 55.0a2 (2017-03-31)
Devices: 
-HTC Nexus 9 (Android 7.1.1)
-Huawei Honor 8 (Android 6.0)
-LG G4 (Android 5.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.