Use calc(50% - 1px) instead of 49.5% in boxmodel.css

RESOLVED FIXED in Firefox 55

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: ntim, Assigned: lockhart)

Tracking

(Depends on 1 bug)

unspecified
Firefox 55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

No longer blocks: 940275
Component: Developer Tools → Developer Tools: Inspector
Depends on: 1150496
Priority: -- → P3
Could you please be more specific in this bug title? Where is this needed, why?
Thanks!
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 2

2 years ago
See https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed72c2f16d8#l4.176

We seem to use 49.5%, because we want to center the label taking in account the line, so calc(50% - 1px) or calc(50% - 0.5px) would be more accurate.
Flags: needinfo?(ntim.bugs)
Summary: Use calc(50% - 1px) instead of 49.5% → Use calc(50% - 1px) instead of 49.5% in boxmodel.css
Assignee: nobody → lockhart

Comment 4

2 years ago
mozreview-review
Comment on attachment 8848259 [details]
Bug 1347619 - Change boxmodel.css to use calc(50% - 1px) instead of 49.5%.

https://reviewboard.mozilla.org/r/121198/#review123210
Attachment #8848259 - Flags: review?(gl) → review+

Comment 5

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b66398167216
Change boxmodel.css to use calc(50% - 1px) instead of 49.5%. r=gl
Status: NEW → ASSIGNED

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b66398167216
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.