1347627 - Add-on installation pop-ups point to “Show site information” icon in about:newtab

Status: RESOLVED DUPLICATE of bug 1347170

(Firefox :: Site Identity, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-03-15_1838.png

[Affected versions]:
Firefox 55.0a1 (2017-03-15)
Firefox 54.0a2 (2017-03-15)
Firefox 53.0b2 (20170313154936)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 14.04 64-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Open a new tab.
3.Open the Menu bar -> File -> Open File.
4.Select an add-on.  


[Expected Results]:
Add-on installation pop-up points to the puzzle icon while installing in a new tab.

[Actual Results]:
- Puzzle icon is not displayed in toolbar and the add-on installation pop-up indicates to “Show site information” icon.
- See attached screenshot.

[Regression Range]: 
Last good revision: 06429d283d5b465e5c484dc6a7447ad03b2589c0
First bad revision: 1955f4507d13e7c834a90260fe6205f338a45a76
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=06429d283d5b465e5c484dc6a7447ad03b2589c0&tochange=1955f4507d13e7c834a90260fe6205f338a45a76

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1300755

Comment 1

[Johann Hofmann [:johannh]]

Yeah this is a side effect of that bug, but I'm not sure how actionable/urgent this is. Let's talk about it in triage.

Markus, assuming this is non-trivial to fix, how much does the user experience suffer from this?

Comment 2

[Markus Jaritz [:designakt] (UX)]

That looks strange, but user experience wouldn't suffer much. 
Especially as it is only triggered by installing a local xpi.
(also happens on drag and drop by the way.)

Comment 3

[Johann Hofmann [:johannh]]

Duping this with bug 1347170 since I think the cause is the same.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix optional here since it's a duplicate.