Closed
Bug 1347634
Opened 8 years ago
Closed 8 years ago
GetCustomElementData should be non-virtual and inline
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: smaug, Assigned: edgar)
References
Details
Attachments
(1 file, 1 obsolete file)
8.45 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
It is used in some very hot code paths.
Updated•8 years ago
|
Whiteboard: [qf-]
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → echen
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8847895 [details] [diff] [review] Patch, v1 Review of attachment 8847895 [details] [diff] [review]: ----------------------------------------------------------------- And SetCustomElementData don't need to be virtual, either.
Attachment #8847895 -
Flags: review?(bugs)
Assignee | ||
Comment 3•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebbcd7f68b4e4867bff12cb23a8c47de0a6a1d7f&group_state=expanded&filter-tier=1
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8847895 [details] [diff] [review] Patch, v1 + nsDOMSlots *slots = GetExistingDOMSlots(); nit, nsDOMSlots* slots It would be even nicer to move Get/SetCustomElementData to Element class, since looks like all the callers deal with Element already. And then + /** + * Sets the custom element data, ownership of the + * callback data is taken by this content. s/taken by this content/taken by this element/ With those, r+ Thanks!
Attachment #8847895 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Address review comment #4, - move Get/SetCustomElementData to Element - Fix comment: s/taken by this content/taken by this element/
Attachment #8847895 -
Attachment is obsolete: true
Attachment #8848392 -
Flags: review+
Assignee | ||
Comment 6•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=56ed9aaca639733662dce29e2483a976b9ea01c4&group_state=expanded&filter-tier=1
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f08f950287 GetCustomElementData and SetCustomElementData don't need to be virtual; r=smaug
![]() |
||
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7f08f950287
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Updated•3 years ago
|
Performance Impact: --- → -
Whiteboard: [qf-]
You need to log in
before you can comment on or make changes to this bug.
Description
•