1347634 - GetCustomElementData should be non-virtual and inline

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

It is used in some very hot code paths.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8847895 [details] [diff] [review]
Patch, v1

Review of attachment 8847895 [details] [diff] [review]:
-----------------------------------------------------------------

And SetCustomElementData don't need to be virtual, either.

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebbcd7f68b4e4867bff12cb23a8c47de0a6a1d7f&group_state=expanded&filter-tier=1

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8847895 [details] [diff] [review]
Patch, v1

+    nsDOMSlots *slots = GetExistingDOMSlots();
nit, nsDOMSlots* slots

It would be even nicer to move Get/SetCustomElementData to Element class, since looks like all the callers deal with Element already.

And then
+  /**
+   * Sets the custom element data, ownership of the
+   * callback data is taken by this content.
s/taken by this content/taken by this element/

With those, r+
Thanks!

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Patch, v2, r=smaug

Address review comment #4,
- move Get/SetCustomElementData to Element
- Fix comment: s/taken by this content/taken by this element/

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=56ed9aaca639733662dce29e2483a976b9ea01c4&group_state=expanded&filter-tier=1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f08f950287
GetCustomElementData and SetCustomElementData don't need to be virtual; r=smaug

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f7f08f950287