1347639 - nsImageLoadingContent::UpdateImageState shouldn't do useless QIs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

There really should be better ways to access nsIContent* than
http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/dom/base/nsImageLoadingContent.cpp#1026

Comment 1

[Boris Zbarsky [:bzbarsky]]

Obvious options are:

1)  A virtual IsContent() that subclasses override.
2)  An nsIContent* ctor arg subclasses pass in and we store, at the cost of an extra word of memory.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Add nsImageLoadingContent::AsContent to make getting the relevant nsIContent* faster

MozReview-Commit-ID: 9sE3pbHwYbV

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8847959 [details] [diff] [review]
Add nsImageLoadingContent::AsContent to make getting the relevant nsIContent* faster

Review of attachment 8847959 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLObjectElement.h
@@ +253,5 @@
>    void StartObjectLoad(bool aNotify, bool aForceLoad);
>  
> +protected:
> +  // Override for nsImageLoadingContent.
> +  nsIContent* AsContent() override { return this; }  

Nit: trailing whitespace, here and a few other headers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc19d7604b6e
Add nsImageLoadingContent::AsContent to make getting the relevant nsIContent* faster.  r=qdot

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cc19d7604b6e