13477 - MLK: HTTP Channel or Request?

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Bruce Mitchener]

This was from a September 7, 1999 build on NT.

[W] MLK: Memory leak of 40 bytes from 1 block allocated in
nsHTTPHeaderArray::SetHeader(nsIAtom *,char const*)
        Distribution of leaked blocks
                40 bytes from 1 block of 40 bytes (0x07098858) allocation number
206649
        Allocation location
            new(UINT)      [new.cpp:23]
            nsHTTPHeaderArray::SetHeader(nsIAtom *,char const*)
[nsHTTPHeaderArray.cpp:113]
            nsHTTPRequest::SetHeader(nsIAtom *,char const*)
[nsHTTPRequest.cpp:380]
            nsHTTPChannel::Init(nsILoadGroup *) [nsHTTPChannel.cpp:517]
            nsHTTPHandler::NewChannel(char const*,nsIURI *,nsILoadGroup
*,nsIEventSinkGetter *,nsIChannel * *) [nsHTTPHandler.cpp:175]
            nsIOService::NewChannelFromURI(char const*,nsIURI *,nsILoadGroup
*,nsIEventSinkGetter *,nsIChannel * *) [nsIOService.cpp:229]
            NS_OpenURI(nsIChannel * *,nsIURI *,nsILoadGroup *,nsIEventSinkGetter
*) [nsNeckoUtil.cpp:63]
            ImageNetContextImpl::GetURL(ilIURL *,NET_ReloadMethod,ilINetReader
*) [nsImageNetContextAsync.cpp:603]
            IL_GetImage    [if.cpp:2027]
            ImageRequestImpl::Init(void *,char const*,nsIImageRequestObserver
*,UINT const*,UINT,UINT,UINT,ilINetContext *) [nsImageRequest.cpp:242]
            ImageGroupImpl::GetImage(char const*,nsIImageRequestObserver *,UINT
const*,UINT,UINT,UINT) [nsImageGroup.cpp:272]
            nsFrameImageLoader::Init(nsIPresContext *,nsIImageGroup *,nsString
const&,UINT const*,nsSize const*,nsIFrame *,(*)(nsIPresContext
*,nsIFrameImageLoader *,nsIFrame *,void *,UINT),void *)
[nsFrameImageLoader.cpp:193]
            nsPresContext::StartLoadImage(nsString const&,UINT const*,nsSize
const*,nsIFrame *,(*)(nsIPresContext *,nsIFrameImageLoader *,nsIFrame *,void
*,UINT),void *,nsIFrameImageLoader * *) [nsPresContext.cpp:846]
            nsHTMLImageLoader::StartLoadImage(nsIPresContext *)
[nsHTMLImageLoader.cpp:178]
            nsHTMLImageLoader::GetDesiredSize(nsIPresContext *,nsHTMLReflowState
const*,nsHTMLReflowMetrics&) [nsHTMLImageLoader.cpp:324]

Comment 1

[Bruce Mitchener]

This set of leaks is huge and is leaking over 80k when merely loading 2 pages
over HTTP in viewer. (I went to http://www.visa.com and then followed the link
for back-to-school specials).  In addition, this adds a lot of noise to Purify
output.

Comment 2

[rpotts (gone)]

hey bruce,
According to the NSPR logging, the HTTPChannel, HTTPRequest and
HTTPResponseListener are all getting deleted...  It looks like it is leaking
nsHTTPHeaderEntries...

I'm looking into it...

Comment 3

[rpotts (gone)]

I've just checked in the fix to nsHTTPHeaderArray.cpp

nsHeaderEntry structs were being leaked.

Comment 4

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Comment 5

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/19b01e323207
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13477 - Move BiometricPrompt to a separate feature (https://github.com/mozilla-mobile/fenix/pull/16498)