1347726 - Clicking "save all" button in new autoclassify UI breaks n/p shortcuts

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Using the new autoclassify ui, if I click the "save all" button, the n/p keyboard shortcuts stop working. It doesn't do that for the "save" button.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:prevent_default_focus > mozilla:master

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8848155 [details] [review]
[treeherder] mozilla:prevent_default_focus > mozilla:master

I don't know if this is the right approach, but I thought I'd throw it up to get some feedback.

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8848155 [details] [review]
[treeherder] mozilla:prevent_default_focus > mozilla:master

This seems reasonable to me.  :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/40dc9ee93aadc3484ec6970a97f4ff7341890eb7
Bug 1347726 - Prevent prevent-default-on-left-click elements retaining focus

Elements like toolbar buttons can be clicked and then become
disabled. In this case they will eat keyboard shortcuts leading to
bugs. A simplisitic fix is just to ensure that those elements give up
focus after they are activated.