Closed
Bug 1347727
Opened 7 years ago
Closed 7 years ago
Enable outer box shadows by default in WR
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
(Regressed 1 open bug)
Details
Attachments
(1 file)
|
14.52 KB,
patch
|
rhunt
:
review+
|
Details | Diff | Splinter Review |
WR doesn't support all cases such as box shadows with a border-radius properly, so we fallback to the old path in those cases. Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=73ecc6bd01441d60344eb9812cf7bb54eff02d50
Attachment #8847808 -
Flags: review?(rhunt)
|
||
Updated•7 years ago
|
Attachment #8847808 -
Flags: review?(rhunt) → review+
Pushed by mchang@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/08e550a5745c Detect box shadow outer cases that WR doesn't support and don't enable a layer for it in WR. r=rhunt
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
Assignee | |
Comment 2•7 years ago
|
||
Still isn't enabled until I figure out https://github.com/servo/webrender/issues/990. But wanted to land to prevent bitrot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•7 years ago
|
Blocks: wr-displayitems
Pushed by mchang@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/6b6847ceb7c9 Enable outer box shadows by default in WR. r=rhunt
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•7 years ago
|
||
Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8b6282847caa33faf4dd3274e21560b299458a3&selectedJob=87434700 X6 permafail is bug 1351777.
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b6847ceb7c9
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•