Closed Bug 1347727 Opened 3 years ago Closed 3 years ago

Enable outer box shadows by default in WR

Categories

(Core :: Graphics: WebRender, enhancement)

51 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

WR doesn't support all cases such as box shadows with a border-radius properly, so we fallback to the old path in those cases.

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=73ecc6bd01441d60344eb9812cf7bb54eff02d50
Attachment #8847808 - Flags: review?(rhunt)
Attachment #8847808 - Flags: review?(rhunt) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/08e550a5745c
Detect box shadow outer cases that WR doesn't support and don't enable a layer for it in WR. r=rhunt
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Still isn't enabled until I figure out https://github.com/servo/webrender/issues/990. But wanted to land to prevent bitrot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1350004
Depends on: 1351114
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/6b6847ceb7c9
Enable outer box shadows by default in WR. r=rhunt
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.