1347732 - Retriggerable actions don't interpret context correctly

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[William Lachance (:wlach)]

According to the specification (http://gecko.readthedocs.io/en/latest/taskcluster/taskcluster/action-spec.html#action-kind-task), we should filter out tasks that don't match *any* of the different context options but I'm filtering out those that don't match *every* context option (which is a problem when you have a context like [{'test-type': 'mochitest'}, {'test-type': 'reftest'}])

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1347732 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8847816 [details] [review]
[treeherder] wlach:1347732 > mozilla:master

Could you have a look at this Brian? I believe this faithfully implements the spec as laid out by Jonas. Certainly things now work for retriggering reftests + mochitests, whereas they didn't before.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/584bc84b0cc42166d576006874e0e5d7eb8799da
Bug 1347732 - Fix interpretation of "context" for taskcluster actions (#2259)