134782 - (classic osx) Scrollbar has wrong value when choosing back or forward

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Prachi Gauriar]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.9+)
Gecko/20020401
BuildID:    2002040108

When using the Classic theme, if either of the scrollbars has moved from the
most left and top of a webpage (we'll call it page A), and the user clicks a
link and hits back to go back to page A, the site is scrolled to the same place
as it was before. However, the scrollbars are drawn as though the page was
scrolled at the very upper-left.

Reproducible: Always
Steps to Reproduce:
1. Visit a site (mozilla.org for example).
2. Scroll all the way to the bottom.
3. Go to another site in the same window/tab.
4. Hit the back button.

Actual Results:  The page is scrolled at the bottom, but the scroll bar is at
the top of the track.

Expected Results:  The scrollbar should be at the bottom of the track.

I'm going to attach an image for you all to see what I'm talking about. It's
kind of hard to describe, but very easy to see. 

Also, this could have to do with pinkerton's fix for bug 121440, but I'm not sure.

Comment 1

[Prachi Gauriar]

Attachment: Screenshot that displays bug (jpeg format)

This is a screenshot of Mozilla.org scrolled to the bottom. As you can see, the
vertical scrollbar is at the top. This only happened once I clicked the back
button to get back to this page.

Comment 2

[Prachi Gauriar]

Attachment: Same image, PNG format

Comment 3

[John Morrison]

works on win2k

-> pinkerton

Comment 4

[Mike Pinkerton (not reading bugmail)]

curious, i wonder why.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Attachment: pick up curpos attribute at scrollbar creation

this fixes it.

Comment 6

[Mike Pinkerton (not reading bugmail)]

looking for r/sr. 

Comment 7

[Conrad Carlen (not reading bugmail)]

Comment on attachment 77226 [details] [diff] [review]
pick up curpos attribute at scrollbar creation

r=ccarlen

Comment 8

[Blake Ross]

Comment on attachment 77226 [details] [diff] [review]
pick up curpos attribute at scrollbar creation

sr=blake

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 77226 [details] [diff] [review]
pick up curpos attribute at scrollbar creation

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 10

[Mike Pinkerton (not reading bugmail)]

Attachment: a better patch that works in all cases

ok, this patch works all the time. i now understand what's going on.

Comment 11

[Conrad Carlen (not reading bugmail)]

Comment on attachment 77459 [details] [diff] [review]
a better patch that works in all cases

It's a little scary that the value can exceed the max, but assuming that
something cleans up the values in the end, r=ccarlen

Comment 12

[Brendan Eich [:brendan]]

Comment on attachment 77459 [details] [diff] [review]
a better patch that works in all cases

sr=[e-mail] -- do you want to file a bug and cite its link instead
of ending that comment with the funky-looking "(bug )", which looks like it is
waiting for a number to be inserted?

/be

Comment 13

[Mike Pinkerton (not reading bugmail)]

good idea brendan, new bug filed
  http://bugzilla.mozilla.org/show_bug.cgi?id=135191

Comment 14

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval for checkin.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 77459 [details] [diff] [review]
a better patch that works in all cases

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[Mike Pinkerton (not reading bugmail)]

landed

Comment 17

[John Morrison]

*** Bug 135739 has been marked as a duplicate of this bug. ***

Comment 18

[John Morrison]

*** Bug 135741 has been marked as a duplicate of this bug. ***

Comment 19

[Prachi Gauriar]

This works now for me. shrirang <[e-mail]> asked me to mark this
verified, so here you go.