1347822 - references in comments to attachments on other bugs shouldn't be augmented with actions

Status: NEW

(bugzilla.mozilla.org :: Bug Creation/Editing, enhancement)

Description

[:glob ✱]

if i reference an attachment by number, eg "a.ttachment1" (without the period), it currently is turned into a href along with the details/diff/review actions.

this can result in weird/confusing text in comments.
eg. from https://bugzilla.mozilla.org/show_bug.cgi?id=1346649#c0
1. Preview appears with very large text, way beyond 80%   [attachment1 [details] [diff] [review].pdf]

i propose always linking to attachments, however only augmenting with details/diff/review for attachments on the current bug.

Comment 1

[Bug Butler]

Attachment: github pull request

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8848995 [details] [review]
github pull request

Currently this fails (returns { html: null },
and the cause isn't obvious because we don't handle errors in the render_comment() method.

If errors *were* working, you'd see:
Can't call method "id" without a package or object reference at /opt/bugzilla/htdocs/1347822/Bugzilla/Template.pm line 295.

Sebastin: Could you file a bug about the lack of error checking here?
https://github.com/mozilla-bteam/bmo/blob/cc3141625e4c87387259c38e4ab5f56820621768/Bugzilla/WebService/Bug.pm#L366-L370

Thanks!

Comment 3

[Dylan Hardison [:dylan] (he/him)]

I think the error triggered here will be more obvious after bug 1361376. Still need to handle the error:

Can't call method "id" without a package or object reference at /opt/bugzilla/htdocs/1347822/Bugzilla/Template.pm line 295.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Is this still being worked on?

Comment 5

[Sebastin Santy [:seban]]

Yep. I'll look into this in some time.