1347826 - New debugger crashes

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect)

Description

[NN]

Attachment: a.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170313154936

Steps to reproduce:

Make a simple page:

<script></script>

Configure new debugger in FF
Open the page
Open debugger
Click on html file in the debugger tab.


Actual results:

Tab crashes.


Expected results:

Show the code

Comment 1

[NN]

Works with single process FF.
Crashes with multi process FF configuration.

Comment 2

[Loic]

I tested in FF53 and FF55 32/64 bits with devtools.debugger.new-debugger-frontend=true on Win 7, I can't reproduce the crash.

Do you have crash reports in about:crashes? If yes, paste some links.

Comment 3

[YF (Yang)]

WFM in Fx53.0 with devtools.debugger.new-debugger-frontend=true and e10s on/off, on Win10.

Comment 4

[NN]

https://crash-stats.mozilla.com/report/index/ce30ab87-49ea-4a05-a579-0f5542170316
https://crash-stats.mozilla.com/report/index/1fe7117b-2eec-45ad-aacd-0a4a22170316
https://crash-stats.mozilla.com/report/index/bp-3a92eef2-ca17-4e5f-bcaf-8e5ef2170316

Comment 5

[NN]

Seems related to https://bugzilla.mozilla.org/show_bug.cgi?id=1346368

Comment 6

[Loic]

Yes, it's probably a duplicate of bug 1346368.

Comment 7

[Jason Laster [:jlast]]

I'm closing this as a duplicate. If it's not, I'm happy to re-open it.

Comment 8

[Dragana Damjanovic [:dragana]]

nn1436401, can you reproduce the crash?
If you can reproduce it it would be really good. From the crash report it is hard to figure out what is wrong.

can you make a log:
https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging

Comment 9

[NN]

Attachment: log.txt-main.18060

Networking log

Comment 10

[NN]

Reproduced using 52.0.2 64-bit.

Comment 11

[Dragana Damjanovic [:dragana]]

(In reply to nn1436401 from comment #9)
> Created attachment 8852784 [details]
> log.txt-main.18060
> 
> Networking log

You colud have a log.txt-child.... file or multiple such files.
Can you also upload them too? Thanks!!!

Comment 12

[NN]

I have only log.txt-main.
Attaching another once

Comment 13

[NN]

Attachment: log.txt-main.18060.zip

Comment 14

[NN]

Open debugger on this page.
Go to show_bug.cgi and see FF tab crahes.

Comment 15

[Dragana Damjanovic [:dragana]]

I cannot reproduce it :( It would me much easier if I could.
I do not see anything in the logs.

I will make a debug build of 53 and ask you to reproduce the crash with some additional logging that only work in debug build

Comment 16

[Dragana Damjanovic [:dragana]]

Here is a debug build of 53. You do not need to install it just download and unpack the zip and run firefox.exe

https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-d7c340acc56c0cae2e42c95dcaec147f0d0aeef4/try-win64-debug/firefox-53.0.en-US.win64.zip

Change into directory where the new firefox.exe is and run this:

set MOZ_IPC_MESSAGE_LOG=1
set MOZ_LOG=timestamp,nsHttp:5
.\firefox.exe > %TEMP%\log.txt 2>&1

this will put the log into %TEMP%\log.txt

Thank you a lot for helping us, really appreciated !!!!!!

Comment 17

[NN]

Attachment: logff.zip

Comment 18

[NN]

Uploaded. Please try.

Comment 19

[Dragana Damjanovic [:dragana]]

Thanks a lot!!!!

From this log I can see what is failing:

NeckoParent::AllocPHttpChannelParent: FATAL error: SerializedLoadContext from child is null: KILLING CHILD PROCESS

I will investigate this tomorrow.

Comment 20

[Dragana Damjanovic [:dragana]]

Ben, do you know what can cause this error? 

NeckoParent::AllocPHttpChannelParent: FATAL error: SerializedLoadContext from child is null: KILLING CHILD PROCESS


The only place where we call SendPHttpChannelConstructor is:

https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/HttpChannelChild.cpp#2449


Thanks!!!

Comment 21

[Dragana Damjanovic [:dragana]]

Removing need-info, not needed.

Comment 22

[Dragana Damjanovic [:dragana]]

I am going to reopen this bug, because there is a lot of details here. (And mark the other one as dup).

Comment 23

[Dragana Damjanovic [:dragana]]

This can be reproduce if network.disable.ipc.security is set to false.

It is related to devtool, so I would like some one from dev-tools to take a look. We do not have LoadContext wherefore it is crashing.

I have seen this comment but I do not know the history of it:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/webide/content/runtimedetails.js#136

Is it possible if you manually change the pref it is going to crash?

Comment 24

[Jason Laster [:jlast]]

Honza, could you take a look?

Comment 25

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce the crash (win10, Nightly) and the link to Fx53 (comment #16) doesn't work anymore.
Not sure how to help here.
Honza