stylo: replace FinishStyle methods on style structs with SequentialTasks

RESOLVED WONTFIX

Status

()

P4
normal
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: heycam, Unassigned)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Now that we have the SequentialTask mechanism, we can probably replace the style struct FinishStyle methods (and probably the nsStyleImageRequest stuff) with them.  This isn't urgent, though.
Why is this needed? We shouldn't compute them off-main-thread, right? if so, why not doing the work in place?
(In reply to Cameron McCormack (:heycam) from comment #0)
> Now that we have the SequentialTask mechanism, we can probably replace the
> style struct FinishStyle methods (and probably the nsStyleImageRequest
> stuff) with them.  This isn't urgent, though.

I think the idea is that it would reduce the overhead of the style struct accessors, since they no longer need to call the out-of-line FinishStyle. The SequentialTasks would only apply to the structs that actually need them.

We would need to figure out a story for what happens when a style struct is cloned during the cascade though. That might be tricky.
Blocks: 1289864
No longer blocks: 1243581
Priority: -- → P4
We discussed IRL today, and decided that this would be a lot of extra sequential tasks. Bug 1376655 is probably a better solution.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.