1347848 - stylo: replace FinishStyle methods on style structs with SequentialTasks

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Cameron McCormack (:heycam)]

Now that we have the SequentialTask mechanism, we can probably replace the style struct FinishStyle methods (and probably the nsStyleImageRequest stuff) with them.  This isn't urgent, though.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Why is this needed? We shouldn't compute them off-main-thread, right? if so, why not doing the work in place?

Comment 2

[Bobby Holley (:bholley)]

(In reply to Cameron McCormack (:heycam) from comment #0)
> Now that we have the SequentialTask mechanism, we can probably replace the
> style struct FinishStyle methods (and probably the nsStyleImageRequest
> stuff) with them.  This isn't urgent, though.

I think the idea is that it would reduce the overhead of the style struct accessors, since they no longer need to call the out-of-line FinishStyle. The SequentialTasks would only apply to the structs that actually need them.

We would need to figure out a story for what happens when a style struct is cloned during the cascade though. That might be tricky.

Comment 3

[Bobby Holley (:bholley)]

We discussed IRL today, and decided that this would be a lot of extra sequential tasks. Bug 1376655 is probably a better solution.