Closed Bug 1347906 Opened 3 years ago Closed 3 years ago

Add .git/.hg to .eslintignore to help speed up full ESLint runs

Categories

(Firefox Build System :: Lint and Formatting, defect)

3 Branch
defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

A week or two ago, I realised that Mercurial checkouts of mozilla-central are much slower than git-cinnabar checkouts.

After some investigation, it appears there's a possible ESLint regression from when they enabled searching for hidden files - because Mercurial has such a large .hg folder (~300,000 files), that slows down ESLint's processing for finding all the files it should be matching against.

I filed the issue here:

https://github.com/eslint/eslint/issues/8259

It was suggested in that issue that we can add .hg to the .eslintignore file to speed things up again, and I've confirmed it does.

For a full eslint run on today's m-c on my Mac:

Unpatched Mercurial Repo: 3m 40
Patch: 2m

I've also tested adding .git for the git repo case - its unclear if it does speed things up (maybe by a few seconds for a 2m-ish run), it certainly doesn't slow it down though.

Hence we should add these to make ESLint runs shorter for our Mercurial developers & build machines.
Comment on attachment 8848057 [details]
Bug 1347906 - Add .git/.hg to .eslintignore to help speed up full ESLint runs.

https://reviewboard.mozilla.org/r/121028/#review122968

Wow awesome find!
Attachment #8848057 - Flags: review?(jaws) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7637cb13054
Add .git/.hg to .eslintignore to help speed up full ESLint runs. r=jaws
https://hg.mozilla.org/mozilla-central/rev/d7637cb13054
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.