1347934 - Not possible to expand XHR JSON array/object to show its contents in Console

Status: RESOLVED INVALID

(DevTools :: Console, defect, P3)

Description

[Vuk Milutinovic]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170302120751

Steps to reproduce:

Bring up Dev Tools, select Console.
Under NET, tick XHR to show page requests.
Page makes a request, GET or POST with url.
Click on "Disclosure Triangle"
Select Response tab
Expand JSON
When there is object or array, click on Disclosure Triangle, everything gets collapsed to GET/POST url


Actual results:

Everything collapses to XHR node, and needs to be expanded again.


Expected results:

JSON array or object should be expanded to show its contents when you click on either Disclosure Triangle or array/object name/ref.

Comment 1

[Loic]

Attachment: sample.json

Comment 2

[Loic]

Attachment: 1347934.html

Comment 3

[Loic]

AFAIK, the Net panel for requests in the Console has been removed in Nightly, there is only Netmonitor and JSON object/arrays are expanded correctly in Nightly.

Comment 4

[Loic]

That said, it's a regression in FF52:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=feb1c52ebe9ef8cff09dea275aa06d9441f5fe93&tochange=500baee3ce9f1b701ace9d38489cbc112d076c72

Patrick Brosset — Bug 1304685 - Show empty text nodes in markupview if they impact layout; r=jdescottes

Comment 5

[Julian Descottes [:jdescottes]]

Regression window seems wrong, I just tried with a changeset preceeding Bug 1304685 (687572ea20cb) and the issue already occurs.

Comment 6

[Loic]

Because you forgot to disable the new frontend for the console. You need to run mozregression with the command --pref "devtools.webconsole.new-frontend-enabled:false".

Could you test again, please.

Comment 7

[Julian Descottes [:jdescottes]]

(In reply to Loic from comment #6)
> Because you forgot to disable the new frontend for the console. You need to
> run mozregression with the command --pref
> "devtools.webconsole.new-frontend-enabled:false".

I did test with the old console frontend.
I could not have reproduced the bug otherwise, this feature is not implemented in the new console.

> Could you test again, please.

Just did a bisect and the regression comes from https://hg.mozilla.org/mozilla-central/rev/cf0fc7add23c which is for Bug 1306840.

It's actually in the regression window you linked. Since this bug was blocked specifically on Bug 1304685, I thought the regression window only contained the changeset for this bug. But it was not the case and I didn't check the link. Sorry about that.

Comment 8

[Loic]

Ah, I see, I guessed wrongly the regressing bug was bug 1304685. :)

Comment 9

[Gerry Chang [:gchang]]

It's too late for 54. Mark 54 won't fix.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Not valid anymore since we're using netmonitor components