1347948 - Report time that channel spent suspended between AsyncOpen and OnStartRequest

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Michal Novotny [:michal]]

We need to make sure that HTTP_NET_VS_CACHE_ONSTART_ probes are not skewed by suspend time.

Comment 1

[Michal Novotny [:michal]]

Attachment: patch

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8848112 [details] [diff] [review]
patch

Review of attachment 8848112 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +8345,5 @@
>  
>      ++mSuspendCount;
>  
> +    if (mSuspendCount == 1) {
> +      mSuspendTimestamp = TimeStamp::NowLoRes();

nit: indent

::: netwerk/protocol/http/nsHttpChannel.h
@@ +518,5 @@
>      uint32_t                          mOfflineCacheLastModifiedTime;
>  
>      mozilla::TimeStamp                mOnStartRequestTimestamp;
> +    mozilla::TimeStamp                mSuspendTimestamp;
> +    uint32_t                          mSuspendTotalTime;

some comments how this is used would be good.

Comment 3

[Michal Novotny [:michal]]

Attachment: patch v2

Comment 4

[Michal Novotny [:michal]]

Comment on attachment 8850966 [details] [diff] [review]
patch v2

We're adding this probe to verify that the large values in HTTP_NET_VS_CACHE_ONSTART_ are not caused by suspending the channel for a long time.

Comment 5

[Benjamin Smedberg]

Comment on attachment 8850966 [details] [diff] [review]
patch v2

data-r=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a73dcfe2c382
Report time that channel spent suspended between AsyncOpen and OnStartRequest. r=honzab, data-review=bsmedberg

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a73dcfe2c382