Checking CanDirectlyActivate() is missing in DispatchSpdyPendingQ

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dragana, Assigned: dragana)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This is a regression from bug 1312774. I notice it while I was rebasing 1341572.
(Assignee)

Updated

2 years ago
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Whiteboard: [necko-active]
(Assignee)

Updated

2 years ago
Blocks: 1312774
Ups, thanks.
(Assignee)

Comment 2

2 years ago
Created attachment 8848120 [details] [diff] [review]
bug_fix_h2_trans_activation.patch
Attachment #8848120 - Flags: review?(honzab.moz)
Comment on attachment 8848120 [details] [diff] [review]
bug_fix_h2_trans_activation.patch

Review of attachment 8848120 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, fixes https://bugzilla.mozilla.org/attachment.cgi?id=8846322&action=diff#a/netwerk/protocol/http/nsHttpConnectionMgr.cpp_sec12

Thanks.
Attachment #8848120 - Flags: review?(honzab.moz) → review+

Comment 4

2 years ago
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/341125a09b13
Check if a h2 connection can accept more streams before trying to dispatchach a transaction. r=mayhemer

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/341125a09b13
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.