1347971 - runtime.onInstalled previousVersion is undefined when extension loaded temporarily

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[testit]

Attachment: testit.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170302120751

Steps to reproduce:

Unzip the attached testcase and load it via "about:debugging". Reload the extension via the reload button. Check the browser console. The value of the property "previousVersion" should be shown. Instead "undefined" is shown. Tested with nightly from 2017-03-16.

Comment 1

[Andrew Swan [:aswan]]

Rob, you want to take a look?

Comment 2

[Robert Helmer [:rhelmer]]

We haven't really considered temporary add-ons to be an upgrade in any sense... I think that's a reasonable expectation for reload though and would allow people to test upgrade paths which is nice.

This means that reload won't be useful for testing new installs though which might not be what people expect... I suppose developers can uninstall via about:addons then reload the add-on via about:debugging which is a bit cumbersome. It might be nice to have an uninstall button in about:debugging to make this a better experience.

There's also the case of loading a temporary add-on ID over an existing ID in a lower-precedence location. I think we should probably preserve the current behavior there though.

Comment 3

[Robert Helmer [:rhelmer]]

Oh nevermind, I ran the test code and see the point here now. We *do* already pass "update" as the install reason, it's just a matter of returning the previous version.

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: Bug 1347971 - pass oldVersion to install and startup methods for temporary add-on reloads

Review commit: https://reviewboard.mozilla.org/r/121164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121164/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8848225 [details]
Bug 1347971 - pass oldVersion to install and startup methods for temporary add-on reloads

https://reviewboard.mozilla.org/r/121164/#review123206

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cacda47d7c81
pass oldVersion to install and startup methods for temporary add-on reloads r=aswan

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cacda47d7c81