134805 - Improvements to the email-address-changing code

Status: NEW

(Bugzilla :: User Accounts, enhancement, P3)

Description

[John Vandenberg]

There were many outstanding issues wrt to bug 23067.

- UI improvements in userpref.cgi
- token expiration date in emails
- speed up transition by allowing old email address to confirm after new email
address
- less scary token cancellation message
- simplify IssueEmailChangeToken
- coding style improvements

Comment 1

[Dave Miller [:justdave]]

as long as the address doesn't change until the new address confirms - the point
is to make sure it's a valid address :-)

under normal circumstances I'd say the old address should HAVE to confirm, but
we're getting around that by requiring the password be entered at the same time,
which I actually think is better.

Comment 2

[John Vandenberg]

Attachment: v1

This patch contains the fixes/restructure that didnt make it into bug 23067.

Comment 3

[Matthew Tuck [:CodeMachine]]

Can this be split up into one patch per issue?  It would make review easier.

Comment 4

[John Vandenberg]

Sure.  Should separate issues be raised for each as well?  Are any of these 2.16
candidates?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

>Should separate issues be raised for each as well?

Yes please.  "one bug -> one report -> one patch" works best most of the time.

Comment 6

[John Vandenberg]

I have created the following issues to break down this patch.

Bug 135812 - mail template administration
Bug 135817 - templatise Token.pm
Bug 135820 - token cancellation message are not user-friendly 
Bug 135828 - email change process requires polish
Bug 135835 - speed up email change process
Bug 135836 - change requests should inlcude expiration details

Comment 7

[Bradley Baetz (:bbaetz)]

Comment on attachment 77192 [details] [diff] [review]
v1

This was split up; needs-work,

Comment 8

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 9

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.