Update RemotePageManager to expose portId on public interface

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: k88hudson, Assigned: k88hudson)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
In ActivityStream, we need to be able to store a reference to a message's port as a string. We can easily do this if the portId property is exposed on a port's public interface in the RemotePageManager.
Assignee

Updated

2 years ago
Assignee: nobody → khudson
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8848583 [details]
Bug 1348124 Update RemotePageManager to expose portId on public interface

https://reviewboard.mozilla.org/r/121482/#review123568
Attachment #8848583 - Flags: review?(dtownsend) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 39e57fb82b57 needs "Bug N" or "No bug" in the commit message.
remote: k88hudson <khudson@mozilla.com>
remote: Bug1348124 Update RemotePageManager to expose portId on public interface r=mossop
remote: 
remote: MozReview-Commit-ID: BYCI9zi6YLh
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/dee306a051f3
Update RemotePageManager to expose portId on public interface r=mossop
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dee306a051f3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.