Closed Bug 1348124 Opened 8 years ago Closed 8 years ago

Update RemotePageManager to expose portId on public interface

Categories

(Firefox Graveyard :: Activity Streams: General, enhancement)

Product:
Firefox Graveyard
Component:
Activity Streams: General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

Details

Attachments

(1 file)

Bug 1348124 Update RemotePageManager to expose portId on public interface
59 bytes, text/x-review-board-request
mossop
: review+
Details
In ActivityStream, we need to be able to store a reference to a message's port as a string. We can easily do this if the portId property is exposed on a port's public interface in the RemotePageManager.
Assignee: nobody → khudson
Comment on attachment 8848583 [details] Bug 1348124 Update RemotePageManager to expose portId on public interface https://reviewboard.mozilla.org/r/121482/#review123568
Attachment #8848583 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: remote: remote: ************************** ERROR **************************** remote: Rev 39e57fb82b57 needs "Bug N" or "No bug" in the commit message. remote: k88hudson <khudson@mozilla.com> remote: Bug1348124 Update RemotePageManager to expose portId on public interface r=mossop remote: remote: MozReview-Commit-ID: BYCI9zi6YLh remote: ************************************************************* remote: remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.c_commitmessage hook failed abort: push failed on remote
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/dee306a051f3 Update RemotePageManager to expose portId on public interface r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dee306a051f3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: