1348177 - Remove GetProcAddress for shell32 since we support Windows 7+

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Makoto Kato [:m_kato]]

For compatibility of Windows XP, we use GetProcAddress to use Vista or 7+ API.  But now, we drop XP and Vista support, so we remove it.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1348177 - Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part).

Since we drop XP support, it is unnecessary to use SHGetStockIconInfo via LoadLibrary.

Review commit: https://reviewboard.mozilla.org/r/121276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121276/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1348177 - Part 2. Remove GetProcAddress for shell32 to use Vista+/7+ API (tookit part).

It is unnecessary to use Vista/7+ API via GetProcAddress.

Review commit: https://reviewboard.mozilla.org/r/121278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121278/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1348177 - Part 3. Remove GetProcAddress for shell32 to use Vista+/7+ API (widget part).

It is unnecessary to use Vista/7+ API via GetProcAddress

Review commit: https://reviewboard.mozilla.org/r/121280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121280/

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8848378 [details]
Bug 1348177 - Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part).

https://reviewboard.mozilla.org/r/121276/#review123316

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8848378 [details]
Bug 1348177 - Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part).

https://reviewboard.mozilla.org/r/121276/#review126788

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8848379 [details]
Bug 1348177 - Part 2. Remove GetProcAddress for shell32 to use Vista+/7+ API (tookit part).

https://reviewboard.mozilla.org/r/121278/#review126790

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8848380 [details]
Bug 1348177 - Part 3. Remove GetProcAddress for shell32 to use Vista+/7+ API (widget part).

https://reviewboard.mozilla.org/r/121280/#review126792

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c591fb03fe
Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part). r=jimm,tnikkel
https://hg.mozilla.org/integration/autoland/rev/c8c7fbbee8a8
Part 2. Remove GetProcAddress for shell32 to use Vista+/7+ API (tookit part). r=jimm
https://hg.mozilla.org/integration/autoland/rev/134a3c1bf3d1
Part 3. Remove GetProcAddress for shell32 to use Vista+/7+ API (widget part). r=jimm

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a4c591fb03fe
https://hg.mozilla.org/mozilla-central/rev/c8c7fbbee8a8
https://hg.mozilla.org/mozilla-central/rev/134a3c1bf3d1