Remove GetProcAddress for shell32 since we support Windows 7+

RESOLVED FIXED in Firefox 55

Status

()

Core
General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

55 Branch
mozilla55
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

7 months ago
For compatibility of Windows XP, we use GetProcAddress to use Vista or 7+ API.  But now, we drop XP and Vista support, so we remove it.

Updated

7 months ago
Blocks: 1130266
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8848378 - Flags: review?(jmathies)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8848378 [details]
Bug 1348177 - Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part).

https://reviewboard.mozilla.org/r/121276/#review123316
Attachment #8848378 - Flags: review?(tnikkel) → review+

Comment 5

7 months ago
mozreview-review
Comment on attachment 8848378 [details]
Bug 1348177 - Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part).

https://reviewboard.mozilla.org/r/121276/#review126788
Attachment #8848378 - Flags: review?(jmathies) → review+

Comment 6

7 months ago
mozreview-review
Comment on attachment 8848379 [details]
Bug 1348177 - Part 2. Remove GetProcAddress for shell32 to use Vista+/7+ API (tookit part).

https://reviewboard.mozilla.org/r/121278/#review126790
Attachment #8848379 - Flags: review?(jmathies) → review+

Comment 7

7 months ago
mozreview-review
Comment on attachment 8848380 [details]
Bug 1348177 - Part 3. Remove GetProcAddress for shell32 to use Vista+/7+ API (widget part).

https://reviewboard.mozilla.org/r/121280/#review126792
Attachment #8848380 - Flags: review?(jmathies) → review+

Comment 8

7 months ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/a4c591fb03fe
Part 1. Remove GetProcAddress for shell32 to use Vista+ API (image part). r=jimm,tnikkel
https://hg.mozilla.org/integration/autoland/rev/c8c7fbbee8a8
Part 2. Remove GetProcAddress for shell32 to use Vista+/7+ API (tookit part). r=jimm
https://hg.mozilla.org/integration/autoland/rev/134a3c1bf3d1
Part 3. Remove GetProcAddress for shell32 to use Vista+/7+ API (widget part). r=jimm

Comment 9

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a4c591fb03fe
https://hg.mozilla.org/mozilla-central/rev/c8c7fbbee8a8
https://hg.mozilla.org/mozilla-central/rev/134a3c1bf3d1
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.