1348181 - [webvtt] fix webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tree-building.html

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Comment 1

[Benjamin Chen [:bechen]]

The input is: <ruby>test<rt>test</ruby>test
The problem is that when we parse the "/" character, we only close the latest tag <rt>, we should close the <ruby> tag either.

Comment 2

[Benjamin Chen [:bechen]]

Attachment: Bug 1348181 - </ruby> can also close the <rt>.

Review commit: https://reviewboard.mozilla.org/r/121354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121354/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8848436 [details]
Bug 1348181 - </ruby> can also close the <rt>.

https://reviewboard.mozilla.org/r/121354/#review123800

::: dom/media/webvtt/vtt.jsm:406
(Diff revision 1)
> +          var endTag = t.substr(2).replace(">", "");
> +          if (tagStack.length && tagStack[tagStack.length - 1] === endTag) {
>              tagStack.pop();
>              current = current.parentNode;
> +          } else if (tagStack.length &&
> +                     tagStack[tagStack.length - 1] === "rt" && endTag ==="ruby") {

nits : add one space before "ruby"

::: dom/media/webvtt/vtt.jsm:408
(Diff revision 1)
>              tagStack.pop();
>              current = current.parentNode;
> +          } else if (tagStack.length &&
> +                     tagStack[tagStack.length - 1] === "rt" && endTag ==="ruby") {
> +            tagStack.pop();
> +            current = current.parentNode;

nits : could we share these codes for both cases?
//
tagStack.pop();
current = current.parentNode;
//

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1348181 - update VTT parser so </ruby> also closes <rt>; r?alwu

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/668e608216c6
update VTT parser so </ruby> also closes <rt>; r=alwu

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46123 for changes under testing/web-platform/tests

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/668e608216c6

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot