1348195 - Investigate if nsRange has same bug as bug 1347809

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

+++ This bug was initially created as a clone of Bug #1347809 +++

nsRange calls Selection::NotifySelectionListeners(). At this time, it doesn't change *its* mCalledByJS to false. Therefore, if it's internal methods are called during a call of Selection::NotifySelectionListeners(), it treats the call as called by JS.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=39e889e2fe2b

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1348195 nsRange should set mCalledByJS to false before calling Selection::NotifySelectionListners() because non-*JS() methods may be called during a call of it

When nsRange::*JS() is called, mCalledByJS is set to true.  In such case, Selection::NotifySelectionListeners() may move focus or anyway, it calls selection listeners.  Then, they may cause calling non-*JS() methods of the nsRange instance. In this case, nsRange treats the call as called by JS since mCalledByJS is still true.

For preventing this issue, before calling Selection::NotifySelectionListeners(), nsRange should set mCalledByJS to false.

This patch renames AutoCalledByJSSetter to AutoCalledByJSRestore and make it stop setting mCalledByJS automatically.  So, AutoCalledByJSRestore works same as AutoRestore now.

Review commit: https://reviewboard.mozilla.org/r/121368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121368/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8848450 [details]
Bug 1348195 nsRange should set mCalledByJS to false before calling Selection::NotifySelectionListners() because non-*JS() methods may be called during a call of it

https://reviewboard.mozilla.org/r/121368/#review123434

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2f781a18186
nsRange should set mCalledByJS to false before calling Selection::NotifySelectionListners() because non-*JS() methods may be called during a call of it r=smaug

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b2f781a18186