Closed Bug 1348258 Opened 7 years ago Closed 7 years ago

ElementNode Rep in the CSS Grid layout panel should not show all attributes

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:
- open this URL
data:text/html,<div test="test" style="display:grid;grid-template-rows:repeat(50, 100px);grid-template-columns:repeat(20, 100px);">
- open the css grid panel in the inspector sidebar

=> the div that has the grid defined is listed there, and previewed using an ElementNode Rep.

Right now, this Rep shows all attributes, but I don't think that's useful, and it takes a lot of space.
I think it should display nodes just like the animation inspector does, like:
tag#id.class
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8848456 [details]
Bug 1348258 - Use MODE.TINY for ElementNodes displayed in the grid inspector;

https://reviewboard.mozilla.org/r/121372/#review123410

Looks good !
Attachment #8848456 - Flags: review?(chevobbe.nicolas) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb5c698bff0a
Use MODE.TINY for ElementNodes displayed in the grid inspector; r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/bb5c698bff0a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: