1348264 - Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1348264 - Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons.

Review commit: https://reviewboard.mozilla.org/r/121388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121388/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8848466 [details]
Bug 1348264 - Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121388/diff/1-2/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8848466 [details]
Bug 1348264 - Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons.

https://reviewboard.mozilla.org/r/121388/#review125436

Nice improvement, thanks! I couldn't find any issues. Apology for the late(r) review, I was out sick the past few days.

::: browser/base/content/browser.js:5486
(Diff revision 2)
>    "new-window-button": "newWindowButton.tooltip",
>    "new-tab-button": "newTabButton.tooltip",
>    "tabs-newtab-button": "newTabButton.tooltip",
> -  "fullscreen-button": "fullscreenButton.tooltip",
> -  "downloads-button": "downloads.tooltip",
> +  "urlbar-reload-button": "reloadButton.tooltip",
> +  "urlbar-stop-button": "stopButton.tooltip",
> +  "urlbar-zoom-button": "urlbar-zoom-button.tooltip",

Thanks for re-ordering these!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42cb4fec923b
Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons. r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42cb4fec923b

Comment 6

[Almas Hossain[:mAlmas]]

I can see this feature implemented in latest Nightly 55.0a1 in windows 10 (64-bit)

Build ID 	20170513030205
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170513]