Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons

RESOLVED FIXED in Firefox 55

Status

()

Firefox
General
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8848466 [details]
Bug 1348264 - Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons.

https://reviewboard.mozilla.org/r/121388/#review125436

Nice improvement, thanks! I couldn't find any issues. Apology for the late(r) review, I was out sick the past few days.

::: browser/base/content/browser.js:5486
(Diff revision 2)
>    "new-window-button": "newWindowButton.tooltip",
>    "new-tab-button": "newTabButton.tooltip",
>    "tabs-newtab-button": "newTabButton.tooltip",
> -  "fullscreen-button": "fullscreenButton.tooltip",
> -  "downloads-button": "downloads.tooltip",
> +  "urlbar-reload-button": "reloadButton.tooltip",
> +  "urlbar-stop-button": "stopButton.tooltip",
> +  "urlbar-zoom-button": "urlbar-zoom-button.tooltip",

Thanks for re-ordering these!
Attachment #8848466 - Flags: review?(mdeboer) → review+

Comment 4

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42cb4fec923b
Expose keyboard shortcuts in tooltips for Stop, Reload and Reset Zoom buttons. r=mikedeboer

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/42cb4fec923b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I can see this feature implemented in latest Nightly 55.0a1 in windows 10 (64-bit)

Build ID 	20170513030205
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170513]
You need to log in before you can comment on or make changes to this bug.