1348271 - Eyedropper in ColorPicker tooltip is not working in the layout panel

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Comment 1

[Julian Descottes [:jdescottes]]

STRs:

- go to http://labs.jensimmons.com/examples/grid-content-1.html
- open devtools > inspector > layout panel
- click on the color picker swatch for any grid container
- in the color picker tooltip, click on the eyedropper icon

ER: eyedropper starts
AR: nothing happens

In the long run we probably want to disable the eyedropper here as it doesn't bring a lot of value. But in the meantime fixing this is a simple one liner.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1348271 - attach eyedropper click event to the proper element;

Review commit: https://reviewboard.mozilla.org/r/121422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121422/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8848485 [details]
Bug 1348271 - attach eyedropper click event to the proper element;

https://reviewboard.mozilla.org/r/121422/#review123416

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d33d81b075f
attach eyedropper click event to the proper element;r=gl

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8848485 [details]
Bug 1348271 - attach eyedropper click event to the proper element;

clearing review flag

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d33d81b075f

Comment 7

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1(2017-03-17) on Windows 10, 64 bit!

The Bug's fix is now verified on Latest Nightly 55.0a1

Build ID 	20170404030204
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170405]

Comment 8

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce the issue on Firefox 55.0a1(2017-03-17), under Windows 10x64.

The issue is still reproducible on Latest Nightly 55.0a1 (2017-04-06) build, when starting FF with a clean profile (See https://goo.gl/E6vRu4).

Note that if the color picker tool is previously enabled from Inspector, the steps from Comment 0 are not reproducible any more. 

Tests were performed under Windows 10x64, Mac OS X 10.12.1 and under Ubuntu 14.04x86. The results were the same on all OSs.

Since the issue is still reproducible, I'm reopening this Bug.

Comment 9

[Julian Descottes [:jdescottes]]

I'm not sure we are talking about the same issue here.

If I understand your STRs correctly you did:
- enable the inspector element picker (top left icon in the devtools toolbox)
- click on color swatch
- click on eyedropper icon
==> bug

It seems that this scenario is indeed creating an issue, but that's not what this bug is about.

This bug is about fixing the eyedropper when using a colorpicker in the layout panel (which is not enabled in your screen recording, you can enable it by going to the devtools options in nightly).

Are you thinking about another bug maybe? 

The bug described here is still fixed on Nightly IMO.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: bug_colorpicker_strs.gif

Here are the STRs that I am testing for this bug

Comment 11

[Mihai Boldan, Desktop QA [:mboldan]]

Thanks Julian for the additional info. 

It seems that it was an error from my side. I've tested by using the Eyedropper option from Computed instead of Layers.

I managed to reproduce the issue on Firefox 54.0a2 (2017-04-09), under Windows 10 x64. 
The issue is no longer reproducible on Firefox 55.0a1 (2017-04-09).
The tests were performed under Windows 10x64, Ubuntu 12.04x86, Mac OS X 10.12.1.

I'm marking this issue Verified Fixed.