Not getting a useful <title> for try pushes.

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: jgraham, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
A try push like https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a2a0673e19d3eb27717b3fe536a3c733e50d48f&selectedJob=84615890 just has "[N] try" as the title, which isn't too useful for working out which try branch is which. It should probbaly take the title from the first commit not containing try syntax, like the emails do (it would be even more useful to be able to set a custom title).
(Reporter)

Updated

a year ago
Blocks: 1045602
(Assignee)

Updated

a year ago
Assignee: nobody → wkocher
Created attachment 8848531 [details] [review]
[treeherder] KWierso:trycommitv2 > mozilla:master
(Assignee)

Comment 2

11 months ago
Comment on attachment 8848531 [details] [review]
[treeherder] KWierso:trycommitv2 > mozilla:master

This fixes the single push titles and adds a selenium test to prove that it works. I'd like to get this landed sooner and then I can add a ui-test for it at a later point, if that works for you.
Attachment #8848531 - Flags: review?(emorley)

Comment 3

11 months ago
Comment on attachment 8848531 [details] [review]
[treeherder] KWierso:trycommitv2 > mozilla:master

Thank you!
Attachment #8848531 - Flags: review?(emorley) → review+

Comment 4

11 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6dc39d6bf98f72ea5c19e79c7417e0f7a84a47a7
Bug 1348276 - Fix getting revision comments for title strings (#2264) r=emorley
(Assignee)

Updated

11 months ago
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.