Grid Inspector lines are too thin on high density display

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Inspector
P3
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: zer0, Assigned: zer0)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
This is a visual regression from bug 1303158: now the grid inspector always deal with physical pixels, therefore lines are thinner on high density displays; makes harder to see the overlay especially with bright colors.

This was initially intended since bug 1187970 was meant for fixing that; but in the team we agreed that would be better use logical pixels instead; checking with UX and designers if they actually have use cases for dealing with sub-pixels.

N.B.
Bug 1187970 still needs to be fixed, but just as meta bug.
(Assignee)

Updated

7 months ago
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8848514 [details]
Bug 1348306 - use the display density pixel ratio to render lines using logical pixels;

https://reviewboard.mozilla.org/r/121436/#review123446

::: commit-message-381f1:1
(Diff revision 1)
> +Bug 1348306 - use the display density pixel ratio to render lines using logical pixels; r=pbro

Notice that this patch is made on top of the one in bug 1348267

Updated

7 months ago
Summary: Grid Inspector: lines are too thinner on high density display → Grid Inspector lines are too thin on high density display

Updated

7 months ago
Blocks: 1181227, 1347964
Priority: -- → P3

Comment 3

7 months ago
mozreview-review
Comment on attachment 8848514 [details]
Bug 1348306 - use the display density pixel ratio to render lines using logical pixels;

https://reviewboard.mozilla.org/r/121436/#review123880

Code changes look good to me. Thanks
Attachment #8848514 - Flags: review?(pbrosset) → review+

Comment 4

7 months ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cde1a20b5a74
use the display density pixel ratio to render lines using logical pixels; r=pbro

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cde1a20b5a74
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 6

6 months ago
[bugday-20170412] 
The bug is no longer to be reproducible in Latest Nightly 55.0a1.
OS:Windows 10
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.