1348342 - Height of blank line increases when hovering over it

Status: RESOLVED FIXED

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Load https://reviewboard.mozilla.org/r/121188/diff/1#index_header
  2. Scroll down to where the code diff begins
  3. Move the mouse up and down over the code lines (without clicking)

Actual results:

  When the mouse is over a blank line, the height of the blank line
  increases slightly (possibly to accommodate the height of the [+]
  icon that moves along with your mouse at the left edge of the lines), 
  pushing lines below it down by a couple of pixels

Expected results:

  Moving the mouse over lines does not change their height.

Note that this does not occur at all full-zoom levels. For me, it happens at 100% zoom and 120% zoom, but not at 110% zoom.

Comment 1

[:glob ✱]

now that you've pointed it out, i cannot unsee.  should be a simple fix.

Comment 2

[:glob ✱]

Attachment: mozreview: ensure empty diff lines are the same height as populated lines (bug 1348342);

showing plus.svg on empty lines slightly increases the height of the line,
pushing all other content on the page down when a blank line is hovered.

Review commit: https://reviewboard.mozilla.org/r/121966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121966/

Comment 3

[Piotr Zalewa [:zalun]]

Comment on attachment 8849135 [details]
mozreview: ensure empty diff lines are the same height as populated lines (bug 1348342);

https://reviewboard.mozilla.org/r/121966/#review124270

++ for the comments

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c32247e16499
mozreview: ensure empty diff lines are the same height as populated lines ; r=zalun