1348355 - Do we need app locale in devtools/shared/system.js ?

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

While working on bug 1347314, :pike posed a question whether we need a locale in:

devtools/shared/system.js:135

and if we do, but not too often, should we retrieve it lazily?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Locale is pretty low priority there.  If it's causing perf issues, it would probably be okay to remove.  `getSystemInfo` is kind of a grab bag of "info we might want about the system".  It originally appeared for WebIDE to list details about Firefox OS phones.

However, we do cache all of `getSystemInfo` after the first call[1], so hopefully there's not too much impact?

[1]: http://searchfox.org/mozilla-central/rev/006005beff40d377cfd2f69d3400633c5ff09127/devtools/shared/system.js#37

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

There shouldn't be, and we cache the result as well so it shouldn't be slow.

Just wanted to check if it's needed at all.

:pike, are you ok closing this bug?

Comment 3

[Axel Hecht [:Pike]]

Right now, the semantics of that value are "a locale that has been set at some point".

If we don't make use of it, I'd prefer to remove it.

Otherwise, I think we should make it a getter, that returns the current locale, and not a value that we cached at some point during startup.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Sounds like let's remove it then.  We can always introduce a better way if we find we want the data in the future.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Cool. Can you wait for me to land bug 1347314 pls? I'd love to avoid bitrot. :)

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #5)
> Cool. Can you wait for me to land bug 1347314 pls? I'd love to avoid bitrot.
> :)

Not sure who "you" is here, but I wasn't planning to make a change here myself.  But yes, whoever takes this on knows to wait now. :)

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ok, I'll either take it or land it as part of the patch in bug 1347314 if I get to do another amend.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

that got fixed in bug 1347314