1348398 - Remove unused Gecko_Truncate[C]String once it is no longer used by stylo

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P5)

Description

[Nika Layzell [:nika] (ni? for response)]

In bug 1347224 the truncate method in the nsstring rust bindings was changed to call SetLength(0) directly. We should make sure to remove the Truncate bindings when they are no longer needed, which we can't do at the same time because of stylo using a copy of nsstring internally (nsstring_vendor).

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Remove Gecko_Truncate[C]String as it is no longer used

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8848631 [details] [diff] [review]
Remove Gecko_Truncate[C]String as it is no longer used

Review of attachment 8848631 [details] [diff] [review]:
-----------------------------------------------------------------

See comments on other bug adding these methods back.  Curious what you think, but will r+ this just so we can move forward with whatever we decide.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Hey emilio - bug 1347224 has landed in central - can you update nsstring_vendor?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1348398: Keep deriving debug in StringRepr.

Review commit: https://reviewboard.mozilla.org/r/122272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122272/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

https://github.com/servo/servo/pull/16056.

Had to add the attached patch so bindings built though.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8849489 [details]
Bug 1348398: Keep deriving debug in StringRepr.

https://reviewboard.mozilla.org/r/122272/#review124438

Oops, not sure how that got removed :S.

Thanks :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd028775ffa
Remove Gecko_Truncate[C]String as it is no longer used, r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/aae2e9c3d129
Keep deriving debug in StringRepr.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3dd028775ffa
https://hg.mozilla.org/mozilla-central/rev/aae2e9c3d129