Only create inset box shadow WR layers for cases WR supports

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

51 Branch
mozilla55
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8848643 [details] [diff] [review]
Inset box shadows

Most of the problem is border radii aren't supported at all with inset box shadows nor weird offsets. Reftests almost pass, just trying to figure out https://github.com/servo/webrender/issues/990, but like to land this before bitrotting.
Attachment #8848643 - Flags: review?(rhunt)

Comment 3

a year ago
Comment on attachment 8848643 [details] [diff] [review]
Inset box shadows

Review of attachment 8848643 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +5069,5 @@
> +      if (!shadowItem->mInset) {
> +        continue;
> +      }
> +
> +      if (shadowItem->mXOffset <=0 || shadowItem->mYOffset <=0) {

Nit: spacing between <= and 0
Attachment #8848643 - Flags: review?(rhunt) → review+

Comment 4

a year ago
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/c637fe322357
Only create inset box shadow WR layers for cases WR supports. r=rhunt
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/c637fe322357
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.