1348408 - Only create inset box shadow WR layers for cases WR supports

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Inset box shadows

Most of the problem is border radii aren't supported at all with inset box shadows nor weird offsets. Reftests almost pass, just trying to figure out https://github.com/servo/webrender/issues/990, but like to land this before bitrotting.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ebbcca66659b2b97e0e9cd1de6ec166785ddf0e

Comment 3

[Ryan Hunt [:rhunt]]

Comment on attachment 8848643 [details] [diff] [review]
Inset box shadows

Review of attachment 8848643 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +5069,5 @@
> +      if (!shadowItem->mInset) {
> +        continue;
> +      }
> +
> +      if (shadowItem->mXOffset <=0 || shadowItem->mYOffset <=0) {

Nit: spacing between <= and 0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/c637fe322357
Only create inset box shadow WR layers for cases WR supports. r=rhunt

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/c637fe322357