Closed Bug 1348408 Opened 3 years ago Closed 3 years ago

Only create inset box shadow WR layers for cases WR supports

Categories

(Core :: Graphics: WebRender, enhancement)

51 Branch
x86
macOS
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mchang, Assigned: mchang)

Details

Attachments

(1 file)

No description provided.
Most of the problem is border radii aren't supported at all with inset box shadows nor weird offsets. Reftests almost pass, just trying to figure out https://github.com/servo/webrender/issues/990, but like to land this before bitrotting.
Attachment #8848643 - Flags: review?(rhunt)
Comment on attachment 8848643 [details] [diff] [review]
Inset box shadows

Review of attachment 8848643 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +5069,5 @@
> +      if (!shadowItem->mInset) {
> +        continue;
> +      }
> +
> +      if (shadowItem->mXOffset <=0 || shadowItem->mYOffset <=0) {

Nit: spacing between <= and 0
Attachment #8848643 - Flags: review?(rhunt) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/c637fe322357
Only create inset box shadow WR layers for cases WR supports. r=rhunt
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.