Closed Bug 1348412 Opened 7 years ago Closed 7 years ago

Add a menu for setting the homepage

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(3 files)

Add menuitems to the same places as "add to home screen"
14.87 KB, patch
snorp
: review+
Details | Diff | Splinter Review
Bug 1348412 - Add dist specific menu for set as homepage.
59 bytes, text/x-review-board-request
snorp
: review+
Details
Screenshots of the flow
180.21 KB, image/png
Details 
We've had a request from a partner to add a menuitem for setting the homepage.

Originally I was going to put it behind a distribution pref, but it seems nonobtrusive based on where the menuitems are going.
Attachment #8848648 - Flags: review?(snorp)
Attachment #8848648 - Flags: review?(snorp) → review+
Assignee: nobody → mozilla
Anthony,

Wanted to make sure you were aware of this.
Flags: needinfo?(alam)
hey guys! Just chiming in here with some UX (and NI-ing Barbara for product input)

Before we proceed further, and ship this to all of our users, I just wanted to ask some questions :)

Why are we adding another menu item for all users? And what does this do exactly? 

Also, how is this different to "Add to Home Screen" in the Page > submenu? 

How will it affect the "Set a Homepage" pref in Home?

Thanks Mike!
Flags: needinfo?(alam) → needinfo?(bbermes)
> Why are we adding another menu item for all users?

The menu was requirement from a partner for preloads and based on how the menus are not any of our main menus, it made sense to me to just make it available globally. If folks feel I should make it available only if a partner requests it I can do that. I also could put it on less menus if that was a concern. The specific requirement is:

Users must be able to set a web page as their browser home page as an option immediately available in the main menu list or the Bookmarks interface. 

> And what does this do exactly?

It sets the selected page as the homepage.

> Also, how is this different to "Add to Home Screen" in the Page > submenu? 

The menu is named poorly. By home screen, they mean your home screen on your phone. It adds an icon on your phone home screen. It does not affect any location in Firefox.

> How will it affect the "Set a Homepage" pref in Home?

It gives an easier way to set that pref from an existing location (URL, page, bookmark)
Thanks Mike! 

Let me talk to Product about this too. 

Although it might seem straightforward, I'm mostly trying to keep the big picture UX-y things in mind. So, I'd like to fully understand the context, the goals, and concerns before making a decision.
This is the exact same patch with visibility moved behind distribution prefs.
Comment on attachment 8851788 [details]
Bug 1348412 - Add dist specific menu for set as homepage.

https://reviewboard.mozilla.org/r/124012/#review126800
Attachment #8851788 - Flags: review?(snorp) → review+
4.5% of our release population (opt-in) have set a custom homepage (https://mzl.la/2oad6PP). That's low, now we could ask, why is it so low, because this customzation option is burried away way too far int our settings, or people really don't want/need it?

I can't tell -- my gut feeling says it would be used more if more people knew about it.

I'd like to propose the following
- Move it behind a distribution pref
- Add UI event telemetry to it so we know if people click / set it
- Wait...and measure, add it to the general population if people in the distro version use this UI to set a homepage


From a UX point, I assume, in order to overwrite the homepage, users would need to go to settings-general-home etc. to update their homepage setting. And for a page opened, that is the homepage, the menu item would be greyed out?

Mike, any way we could get an APK to test this?
Flags: needinfo?(bbermes)
> From a UX point, I assume, in order to overwrite the homepage, users would need to go to settings-general-home etc. to update their homepage setting.

No, the menuitem will always work to update their homepage. They would only need to go to prefs to set it back.

> And for a page opened, that is the homepage, the menu item would be greyed out?

I wasn't planning to do this. This is such an edge case, I don't think it's worth it.
To be clear, the button in the menu will lead to *that* full page in the Settings right?
> To be clear, the button in the menu will lead to *that* full page in the Settings right?

No, the menu will immediately set the homepage. It doesn't take them to settings
Anthony,

Do you have any more comments/questions? Can I check this in behind the pref?
Flags: needinfo?(alam)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/eceaa5f7c928
Add dist specific menu for set as homepage. r=snorp
https://hg.mozilla.org/mozilla-central/rev/eceaa5f7c928
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(In reply to Mike Kaply [:mkaply] from comment #12)
> Anthony,
> 
> Do you have any more comments/questions? Can I check this in behind the pref?

I think it makes the most sense to lead the user to the same full-page Settings page that we already have. That way, we can keep things consistent and familiarize the user with our UX / product. 

But I see this bug has been resolved now anyways. Even though this is behind a pref, let's keep a close eye on this because I still think it's important to keep a consistent experience for something like this.
Flags: needinfo?(alam)
> I think it makes the most sense to lead the user to the same full-page Settings page that we already have. That way, we can keep things consistent and familiarize the user with our UX / product. 

And then have them manually fill in the page? or just show them that it has been filled in?

I guess I'm not understanding here. The point of the menuitem is to immediately set the user's homepage. There's nothing else for them to do...
Could you attach screenshots of the user flow/ experience that you're referring to (behind a pref as you said)? I just want to keep track of all the "Home page" UI/UX we have atm.
Flags: needinfo?(mozilla)
Attached image Screenshots of the flow — 
Here are four screenshots.

The fourth is linked from the Page menu which is why I have the third screenshot.

After clicking the menuitem the page is immediately your homepage with no interaction.
Flags: needinfo?(mozilla)
Ah, sorry I wasn't more clear. I know that these are where the buttons are. 

What was asking for are the sequential screenshots of what happens after each button is pressed - a flow. 

But IIUC, what you're saying is that the menu simply dismisses? then I think we at least need a snack bar confirmation UI. Just like other parts of our product (think bookmarks, closing a tab, etc). 

Do we have anything of the sort?
Flags: needinfo?(mozilla)
(In reply to Anthony Lam (:antlam) from comment #21)
> Ah, sorry I wasn't more clear. I know that these are where the buttons are. 
> 
> What was asking for are the sequential screenshots of what happens after
> each button is pressed - a flow. 
> 
> But IIUC, what you're saying is that the menu simply dismisses? then I think
> we at least need a snack bar confirmation UI. Just like other parts of our
> product (think bookmarks, closing a tab, etc). 
> 
> Do we have anything of the sort?

That's a great idea. I'll add that. Do you think we should have a button for options like bookmarks to point people where it happened? Or is a message enough?
Flags: needinfo?(mozilla)
It's tough to say without testing it out on my device, but I think a snack bar message is fine for now.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: