Closed Bug 1348439 Opened 3 years ago Closed 3 years ago

History item "reporter accessible: true" is confusing

Categories

(bugzilla.mozilla.org :: User Interface, enhancement, P3)

Production
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: umohm12, Mentored)

Details

(Keywords: bmo-small, good-first-bug)

Attachments

(1 file, 1 obsolete file)

PR
44 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
Do you know what "Reporter Accessible: true" means in a bug history?
It means that the bug is not accessible to the reporter. Clear as mud, right?

No.

It needs to say instead "Not accessible to reporter" for true,
and "accessible to reporter" if false.
Attached patch bug1348439.patch (obsolete) — — Splinter Review
Attachment #8856695 - Flags: review?(dylan)
Comment on attachment 8856695 [details] [diff] [review]
bug1348439.patch

This looks good, and it I can confirm it works on my dev instance. 

Needs two things:

1) clean up the trailing spaces around the changes in extensions/BugModal/template/en/default/bug_modal/activity_stream.html.tmpl
I believe there is a cloud9 option for "Strip Whitespace" on save, but I can't remember where.

2) Fix up the patch by removing all the extra files.
Attachment #8856695 - Flags: review?(dylan)
Attached file PR —
Attachment #8873889 - Flags: review?(dylan)
Attachment #8856695 - Attachment is obsolete: true
Comment on attachment 8873889 [details] [review]
PR

r=dylan
Attachment #8873889 - Flags: review?(dylan) → review+
Congrats on your first r+!

To git@github.com:mozilla-bteam/bmo.git
   ef7cfc1b8..c182928f1  master -> master
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.