1348478 - Gecko Decision busted with l10n try push

Status: RESOLVED FIXED

Description

[Edmund Wong (:ewong)]

With this try push,

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e77a2b0530d1c520a0ce64f0ee815cf6c927b4dc

I'm getting a busted Gecko Decision job.

And now I can't seem to manually trigger L10n jobs.

Comment 1

[Edmund Wong (:ewong)]

try: -b do -p win32,win32-l10n,win64,win64-l10n -u none -t none

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed6bd9650c96712051ef6fe08f5613db51c2303f

try: -b do -p win32,win64 -u none -t none

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=84937219

But since no one else is having this issue, I think I might have
horked the Gecko Decision task in an earlier try?

Comment 2

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #1)

> try: -b do -p win32,win64 -u none -t none
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=84937219
> 

Even with the above, I get a broken Gecko Decision bustage with:
Exception: conflict between nightly-l10n-linux-nightly-1/opt:l10n-linux-l10n/opt for route: index.gecko.v2.try.revision.5442ac50c2a408cb0b3e2aacbeba1304be5e2e37.firefox-l10n.linux-opt.de


And I didn't even mention Linux in my try push.  I'm kinda stumped.

Comment 3

[Ed Morley [:emorley]]

Treeherder doesn't schedule the decision tasks, moving to a Taskcluster component.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Callek, can you help out?  I don't really understand the two labels (one says nightly twice, once says l10n twice).

Comment 5

[Justin Wood (:Callek)]

:ewong, for the time being modify: https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/task.py#724  you can get rid of the routes entirely if you want here  (Make it `if True: return task` or modify the number of locales to do that with.

Sadly this is a fault of how I am accomodating the magic "don't do too many routes" *and* the problem of l10n routes not reflecting nightly routes....

Comment 6

[Edmund Wong (:ewong)]

(In reply to Justin Wood (:Callek) from comment #5)
> :ewong, for the time being modify:
> https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/
> transforms/task.py#724  you can get rid of the routes entirely if you want
> here  (Make it `if True: return task` or modify the number of locales to do
> that with.

I only have 1 locale.  I'll try modifying that file.  Thanks

Comment 7

[Edmund Wong (:ewong)]

I changed the code in tasks.py and did a push.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9606df0df17fea050119b7ac95ad98d84e331b83

Even with -p win32..  and no mention of linux, I've got a linux job?

Comment 8

[Justin Wood (:Callek)]

Attachment: Bug 1348478, Gecko Decision busted with l10n try push.

This patch effectively removes indexing from the on-push style l10n tasks. These tasks are currently only used on try.

We don't want the indexing because the index's themselves conflict with the indexes used on Nightly l10n tasks, for now, and would get added here in any full graph if the locale list is small enough. We can revisit this decision whenever on-change L10n for non-try is a thing, and/or when we have explicit nightly routes for l10n

Review commit: https://reviewboard.mozilla.org/r/144272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144272/

Comment 9

[Kim Moir [:kmoir] ET]

Comment on attachment 8872756 [details]
Bug 1348478, Gecko Decision busted with l10n try push.

https://reviewboard.mozilla.org/r/144272/#review148076

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b20f3d4ad0fb
Gecko Decision busted with l10n try push. r=kmoir

Comment 11

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/b20f3d4ad0fb