Closed Bug 1348551 Opened 4 years ago Closed 4 years ago
Wrong button focusring in edit
During work on bug 1348518 I found that the focusring of the delete button is completely wrong. Also the buttons on the bottom don't get the styling from editContactOverlay.css.
Fixed the issue by using the same focus style as editContactAddressBookList uses. I combined the button and menulist rules as they are the same and doubling them makes no sense. Also fixed the selectors to the buttons at the bottom.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8848743 - Flags: review?(aleth)
Comment on attachment 8848743 [details] [diff] [review] editContactPanel.patch Clokep, it seems aleth is away for some time. If you have time, could you look at this?
Comment on attachment 8848743 [details] [diff] [review] editContactPanel.patch Sorry for the delay on this! Thanks for fixing it.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Comment on attachment 8848743 [details] [diff] [review] editContactPanel.patch [Approval Request Comment] User impact if declined: Weird focus ring Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #8848743 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #8848743 - Flags: approval-comm-esr52? → approval-comm-esr52+
You need to log in before you can comment on or make changes to this bug.