1348551 - Wrong button focusring in editContactPanel

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: buttonFocus.png

During work on bug 1348518 I found that the focusring of the delete button is completely wrong. Also the buttons on the bottom don't get the styling from editContactOverlay.css.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: editContactPanel.patch

Fixed the issue by using the same focus style as editContactAddressBookList uses. I combined the button and menulist rules as they are the same and doubling them makes no sense. Also fixed the selectors to the buttons at the bottom.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

Clokep, it seems aleth is away for some time. If you have time, could you look at this?

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

Sorry for the delay on this! Thanks for fixing it.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/3afd5acb7e7d86ad473982405ed9a9da9fd0c821

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

[Approval Request Comment]
User impact if declined: Weird focus ring
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 54):
https://hg.mozilla.org/releases/comm-beta/rev/0292cd5151ac03ae9415ff7af281fb90c59b11a1

Comment 7

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/9b99a2c53e37