Closed Bug 1348551 Opened 3 years ago Closed 3 years ago

Wrong button focusring in editContactPanel

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird_esr5254+ fixed, thunderbird53 wontfix, thunderbird54 fixed, thunderbird55 fixed)

RESOLVED FIXED
Thunderbird 55.0
Tracking Status
thunderbird_esr52 54+ fixed
thunderbird53 --- wontfix
thunderbird54 --- fixed
thunderbird55 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

Attached image buttonFocus.png
During work on bug 1348518 I found that the focusring of the delete button is completely wrong. Also the buttons on the bottom don't get the styling from editContactOverlay.css.
Fixed the issue by using the same focus style as editContactAddressBookList uses. I combined the button and menulist rules as they are the same and doubling them makes no sense. Also fixed the selectors to the buttons at the bottom.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8848743 - Flags: review?(aleth)
Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

Clokep, it seems aleth is away for some time. If you have time, could you look at this?
Attachment #8848743 - Flags: review?(clokep)
Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

Sorry for the delay on this! Thanks for fixing it.
Attachment #8848743 - Flags: review?(clokep)
Attachment #8848743 - Flags: review?(aleth)
Attachment #8848743 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3afd5acb7e7d86ad473982405ed9a9da9fd0c821
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Comment on attachment 8848743 [details] [diff] [review]
editContactPanel.patch

[Approval Request Comment]
User impact if declined: Weird focus ring
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8848743 - Flags: approval-comm-esr52?
Attachment #8848743 - Flags: approval-comm-beta?
Attachment #8848743 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #8848743 - Flags: approval-comm-esr52? → approval-comm-esr52+
You need to log in before you can comment on or make changes to this bug.